-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear selection if value change from pagination=remote
#6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
added
type: bug
Something isn't correct or isn't working
component: tabulator
Related to the Tabulator widget
labels
Dec 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6008 +/- ##
==========================================
+ Coverage 81.10% 81.56% +0.45%
==========================================
Files 319 319
Lines 46892 46927 +35
==========================================
+ Hits 38033 38274 +241
+ Misses 8859 8653 -206 ☔ View full report in Codecov by Sentry. |
ahuang11
reviewed
Dec 12, 2023
philippjfr
reviewed
Jan 12, 2024
philippjfr
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tabulator
Related to the Tabulator widget
type: bug
Something isn't correct or isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value of the Tabulator changes, we can no longer trust the selection; therefore, we clear it.