Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear selection if value change from pagination=remote #6008

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 7, 2023

If the value of the Tabulator changes, we can no longer trust the selection; therefore, we clear it.

@hoxbro hoxbro added type: bug Something isn't correct or isn't working component: tabulator Related to the Tabulator widget labels Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (68749eb) to head (e337e0f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6008      +/-   ##
==========================================
+ Coverage   81.10%   81.56%   +0.45%     
==========================================
  Files         319      319              
  Lines       46892    46927      +35     
==========================================
+ Hits        38033    38274     +241     
+ Misses       8859     8653     -206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as draft December 7, 2023 12:59
setup.py Outdated Show resolved Hide resolved
panel/widgets/tables.py Outdated Show resolved Hide resolved
@hoxbro hoxbro marked this pull request as ready for review June 10, 2024 15:40
@hoxbro hoxbro added this to the v1.5.0 milestone Jun 10, 2024
@hoxbro hoxbro requested a review from philippjfr June 25, 2024 06:55
@philippjfr philippjfr merged commit eb91a2d into main Jun 25, 2024
15 checks passed
@philippjfr philippjfr deleted the clear_selection branch June 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabulator Related to the Tabulator widget type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants