Added geoviews RGB type #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
Jun 29, 2017
| @@ -214,6 +215,28 @@ class Image(_Element, HvImage): | |||
| group = param.String(default='Image') | |||
|
|
|||
|
|
|||
| class RGB(_Element, HvRGB): | |||
There was a problem hiding this comment.
Couldn't _Element have been called CartElement or similar? It has _abstract=True so I don't see the need for the underscore...
There was a problem hiding this comment.
It could have been yes, but at this point I'll just leave it.
There was a problem hiding this comment.
Ok, maybe file an issue for next time.
|
Looks fine to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, adds a geo/crs-aware RGB Element type. Addresses #67