Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify, clean up and upstream CSS #238

Open
maximlt opened this issue Nov 29, 2022 · 0 comments
Open

Identify, clean up and upstream CSS #238

maximlt opened this issue Nov 29, 2022 · 0 comments

Comments

@maximlt
Copy link
Collaborator

maximlt commented Nov 29, 2022

There's a lot of CSS lying around, both in this repo and in the various repos that use NBSite.

In NBSite:

  • nbsite/_shared_static/nbsite.css: dates back to 5 years ago so there's probably lots of it that is obsolete as depending on former themes, but it also has some new rules that are worth having a close look at
  • mystnb.css: in shared_conf.py there's a little function that removes the CSS file distributed by MyST-NB; instead we ship our own version with some changes (what changes?). MyST-NB has made its CSS file more configurable with CSS variables (👌 IMPROVE: Move CSS colors to variables executablebooks/MyST-NB#448), so that might no longer be required. Or it might still be required. Need more investigation!

In a project like Panel you would typically find:

  • custom.css: sets the links colors (shouldn't this be done in conf.py?) and a bunch of mixed CSS rules. Since they're usually quite useful they're (partially) copy/pasted across projects.
  • some more specific CSS, like dataframe.css: depending on how general are those files and the rules they contain, they may or may not need to be upstreamed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant