fix bare_ffmpeg_filter_graph_parse input/output params #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-go
reviewed
Oct 29, 2025
| }) | ||
| }) | ||
|
|
||
| test('FilterGraph.parse should handle multiple inputs', (t) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test('FilterGraph.parse should handle multiple inputs', (t) => { | |
| test('FilterGraph should split one input into multiple outputs', (t) => { |
According to my understanding. I could be wrong tho 😅
| }) | ||
| }) | ||
|
|
||
| test('FilterGraph.parse should handle multiple outputs', (t) => { |
Comment on lines
+92
to
+100
| using inputs = createFilterInOutChain([ | ||
| [sinkContext0, 'out0'], | ||
| [sinkContext1, 'out1'] | ||
| ]) | ||
| using outputs = initOutputs(bufferContext) | ||
|
|
||
| t.execution(() => { | ||
| graph.parse('split=2[out0][out1]', inputs, outputs) | ||
| }) |
Contributor
There was a problem hiding this comment.
According what was added in lib/filter-graph.js. It does not look like we have a test that cover that case (having inputs or ouputs with an undefined _handle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using multiple inputs and outputs with FilterGraph and found that the params for the binding function needed to be updated to use double pointers to fully support the linked lists.