Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-2485 Remove WAF custom rule redirection route #1292

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
11 changes: 0 additions & 11 deletions src/main/controllers/UnprocessedRequestController.ts

This file was deleted.

5 changes: 0 additions & 5 deletions src/main/resources/locales/cy/unprocessed-request.json

This file was deleted.

5 changes: 0 additions & 5 deletions src/main/resources/locales/en/unprocessed-request.json

This file was deleted.

1 change: 0 additions & 1 deletion src/main/routes/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ export default function (app: Application): void {
app.get('/session-expired-logout', (_req, res) => sessionManagement.logOut(_req, res, false, true));
app.get('/session-logged-out', app.locals.container.cradle.sessionLoggedOutController.get);
app.get('/not-found', app.locals.container.cradle.notFoundPageController.get);
app.get('/unprocessed-request', app.locals.container.cradle.unprocessedRequestController.get);

app.get('/search', app.locals.container.cradle.searchController.get);
app.post('/search', app.locals.container.cradle.searchController.post);
Expand Down
19 changes: 0 additions & 19 deletions src/main/views/unprocessed-request.njk

This file was deleted.

49 changes: 24 additions & 25 deletions src/test/a11y/tests/public-routes.test.ts
Original file line number Diff line number Diff line change
@@ -1,28 +1,27 @@
import sinon from 'sinon';
import {LocationRequests} from '../../../main/resources/requests/LocationRequests';
import {PublicationRequests} from '../../../main/resources/requests/PublicationRequests';
import {testArtefactMetadata, testLocationData} from '../common/testData';
import {filterRoutes, testAccessibility} from '../common/pa11yHelper';
import { LocationRequests } from '../../../main/resources/requests/LocationRequests';
import { PublicationRequests } from '../../../main/resources/requests/PublicationRequests';
import { testArtefactMetadata, testLocationData } from '../common/testData';
import { filterRoutes, testAccessibility } from '../common/pa11yHelper';

const publicRoutes = [
{path: '/'},
{path: '/accessibility-statement'},
{path: '/account-request-submitted'},
{path: '/alphabetical-search'},
{path: '/cookie-policy'},
{path: '/create-media-account'},
{path: '/password-change-confirmation', parameter: '/false', postMethod: true},
{path: '/cancelled-password-reset', parameter: '/false'},
{path: '/admin-rejected-login'},
{path: '/media-rejected-login'},
{path: '/session-expired', parameter: '?reSignInUrl=CFT'},
{path: '/session-logged-out'},
{path: '/not-found'},
{path: '/unprocessed-request'},
{path: '/search'},
{path: '/sign-in'},
{path: '/view-option'},
{path: '/summary-of-publications', parameter: '?locationId=123'},
{ path: '/' },
{ path: '/accessibility-statement' },
{ path: '/account-request-submitted' },
{ path: '/alphabetical-search' },
{ path: '/cookie-policy' },
{ path: '/create-media-account' },
{ path: '/password-change-confirmation', parameter: '/false', postMethod: true },
{ path: '/cancelled-password-reset', parameter: '/false' },
{ path: '/admin-rejected-login' },
{ path: '/media-rejected-login' },
{ path: '/session-expired', parameter: '?reSignInUrl=CFT' },
{ path: '/session-logged-out' },
{ path: '/not-found' },
{ path: '/search' },
{ path: '/sign-in' },
{ path: '/view-option' },
{ path: '/summary-of-publications', parameter: '?locationId=123' },
];

const locationData = testLocationData();
Expand All @@ -44,22 +43,22 @@ describe('Accessibility - Public Routes', () => {
describe('A-Z Search Page', () => {
describe('with no input data', () => {
const url = '/search';
testAccessibility(url, '', true, {'search-input': ''});
testAccessibility(url, '', true, { 'search-input': '' });
});
});

describe('Sign-in Page', () => {
describe('with no input data', () => {
const url = '/sign-in';
testAccessibility(url, '', true, {'sign-in': ''});
testAccessibility(url, '', true, { 'sign-in': '' });
});
});

describe('View option Page', () => {
const url = '/view-option';

describe('with no input data', () => {
testAccessibility(url, '', true, {'view-choice': ''});
testAccessibility(url, '', true, { 'view-choice': '' });
});
});
});
Expand Down
14 changes: 0 additions & 14 deletions src/test/routes/unprocessed-request.test.ts

This file was deleted.

29 changes: 0 additions & 29 deletions src/test/unit/controllers/unprocessedRequestController.test.ts

This file was deleted.

50 changes: 0 additions & 50 deletions src/test/unit/views/unprocessed-request.test.ts

This file was deleted.