Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onClose method and isClosable method #2

Open
wants to merge 3 commits into
base: ghpages
Choose a base branch
from

Conversation

mmasdivins
Copy link

I think it could be useful to have a method to close the tab inside the content.
Also, sometimes depending on conditions of the content we may want to forbid the tab to close, so I added an isClosable method on the content that, if defined, the content can control if the tab can be closed or not.
So for example, we want the counter to be closed only when the value is greater than 3 we will do the following:

  ctx.content.isClosable = () => {
      return value > 3;
  };

If the isClosable doesn't define the close button would work normally.

It can probably be done better, that's just how I would do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant