Added onClose method and isClosable method #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it could be useful to have a method to close the tab inside the content.
Also, sometimes depending on conditions of the content we may want to forbid the tab to close, so I added an isClosable method on the content that, if defined, the content can control if the tab can be closed or not.
So for example, we want the counter to be closed only when the value is greater than 3 we will do the following:
If the isClosable doesn't define the close button would work normally.
It can probably be done better, that's just how I would do it.