Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length normalizing and temperature #9

Open
markict123 opened this issue Apr 7, 2024 · 1 comment
Open

Length normalizing and temperature #9

markict123 opened this issue Apr 7, 2024 · 1 comment

Comments

@markict123
Copy link

Thanks for nice work! I have two questions.
The first one is about length norm in calculating the conditional log probability. According to the paper and common practice, the denominator should be the length of response.
image
However, according to the code:

prod.append(-loss/mask.sum(-1))

the denominator seems to include the padding part. Could you please check it?

The second question I wonder is the proper way to show experiment results.
The paper says,
image
Do you mean choosing the best result under each temperature , or choose the best temperature according to Pass@1 or something?
Thank you for reply.

@DevinShang
Copy link
Collaborator

Hi,
Thanks a lot for your issue!
Regarding your first question, you are right and we should only include response part of the mask in the denominator.
For your second issue, we chose the best result under different temperature configurations for each metric, i.e., pass@1, pass@5, pass@10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants