Broken regular expression in PHP 8.4.6

[Aquilosion]

In recent PHP versions (not sure when it broke), the needsEscape regular expression in HJSONStringifier is broken:

preg_match(): Compilation failed: digits missing after \x or in \x{} or \o{} or \N{U+} at offset 149

I'm using PHP 8.4.6 and HJSON 2.3.0.

[trobro]

That line has not been changed since the repo was created nine years ago, and our automatic tests are running on PHP 8.4.6 (and other versions). According to https://regex101.com :

\x matches the character � with index 0 literally (case sensitive)

Do you know why the error is reported in your setup? It would be good to catch errors like that in our automatic tests.

I think I can just remove \x from the end of the regexps since they also contain \x00.

[Aquilosion]

Hmm, I'm not sure! It's running under macOS, but I don't think there are any unusual flags I've set otherwise. It might be something to do with the specific pcre2 library that PHP is using, which I guess can vary.

[Aquilosion]

More info here: pear/Net_URL2#17

[Aquilosion]

Yeah it's definitely a change in PCRE2 10.45: https://github.com/PCRE2Project/pcre2/blob/2dce7761b1831fd3f82a9c2bd5476259d945da4d/NEWS#L35

[trobro]

Thanks for investigating! Can the errors be solved if you remove the \x at the end of the three regexps at lines 18, 20 and 22? I'd rather not mess with my PCRE2 versions.

[Aquilosion]

Yes, that solves the issue.

[trobro]

Thanks, fixed in release v2.3.1.

[Aquilosion]

@trobro When will the update be available on Packagist?

[trobro]

We rely on the weekly Packagist auto-crawling for updates there, I believe the next one is scheduled for tomorrow evening.