Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work for reload #18

Open
nikhil271995 opened this issue Mar 31, 2019 · 5 comments
Open

Doesn't work for reload #18

nikhil271995 opened this issue Mar 31, 2019 · 5 comments

Comments

@nikhil271995
Copy link

If the current route was A and a reload happens on route A and then user moves to route B then last route comes as null instead of A.

@hinok
Copy link
Owner

hinok commented Mar 31, 2019

@nikhil271995 Hey, thanks for reporting the issue.

Probably you meant scenario like this:

  1. Visit /, last = null
  2. Visit /about, last = /
  3. Visit /contact, last = /about
  4. Refresh/reload /contact, last = null

Could you confirm that scenario described by me is what you meant?

@taverasmisael
Copy link

I can confirm scenario 4. The last location is missing if the page is reloaded. Would be great if you could pass a persitor function to the LastLocationProvider . In that case, each user could implement its own lastLocation caching strategy.

@hinok
Copy link
Owner

hinok commented Jun 5, 2019

@taverasmisael Yup, I'm happy to add such functionality to the lib. Will try to finish work on this and #17

@shiro
Copy link

shiro commented Oct 25, 2020

Any update on this?

@Hervera
Copy link

Hervera commented Jul 2, 2021

It still doesn't work on page reload, any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants