Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite Friends #56

Open
himanshusharma89 opened this issue Mar 6, 2021 · 15 comments
Open

Invite Friends #56

himanshusharma89 opened this issue Mar 6, 2021 · 15 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@himanshusharma89
Copy link
Owner

Use dynamic links to share with your friends to invite. Follow up pf #50

@himanshusharma89 himanshusharma89 added Level3 hard gssoc issue enhancement New feature or request labels Mar 6, 2021
@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Mar 6, 2021
@nb9960
Copy link

nb9960 commented Mar 8, 2021

Since this is the follow up of #50 Do I have to work on this as well?

@himanshusharma89
Copy link
Owner Author

Yes @nb9960, but one person can be assigned to one issue at a time.

@nb9960
Copy link

nb9960 commented Mar 8, 2021

Yes @nb9960, but one person can be assigned to one issue at a time.

Okay, but featuring dynamic links using firebase requires setting up firebase first which in itself is a separate issue. Or do one thing generate URL using firebase and provide me that link so that I can start working on #50

@himanshusharma89
Copy link
Owner Author

@nb9960 I'll add you to the firebase console and integration is almost done, just need to review the PR. Share me your Gmail id.

@nb9960
Copy link

nb9960 commented Mar 8, 2021

@nb9960 I'll add you to the firebase console and integration is almost done, just need to review the PR. Share me your Gmail id.

nbodani8@gmail.com

@anotherwebguy
Copy link
Contributor

anotherwebguy commented Mar 10, 2021

Hey @himanshusharma89 here do we only have to share the dynamic links that are generated in issue #50 ?
Like by providing a share button on the products details page?

@nb9960
Copy link

nb9960 commented Mar 10, 2021

Hey @himanshusharma89 i can work on this issue if issue #50 is merged, also can u fill me with details like here we sharing the links to the products right?
So i need to pass the products info in the link ?
Also i need to work on that link generation plus sharing part?
Also after opening app from link it should take you to the product detail page right?
Plz assign me this issue i would like to work on it.
Here's my mail u can add me on firebase console
mohitrajputms123@gmail.com

Hey @anotherwebguy PR for dynamic link integration is not merged yet.
For resolving this issue you just have to create a invite button (maybe in drawer) and pass URL as relicbazaar.page.link/ (without any parameter as this isn't about sharing product, I have already done that part). Other than that as I have already integrated dynamic link you don't have to make any changes through the firebase console or in the codebase to handle the link on app launch

@anotherwebguy
Copy link
Contributor

Hey @himanshusharma89 i can work on this issue if issue #50 is merged, also can u fill me with details like here we sharing the links to the products right?
So i need to pass the products info in the link ?
Also i need to work on that link generation plus sharing part?
Also after opening app from link it should take you to the product detail page right?
Plz assign me this issue i would like to work on it.
Here's my mail u can add me on firebase console
mohitrajputms123@gmail.com

Hey @anotherwebguy PR for dynamic link integration is not merged yet.
For resolving this issue you just have to create a invite button (maybe in drawer) and pass URL as relicbazaar.page.link/ (without any parameter as this isn't about sharing product, I have already done that part). Other than that as I have already integrated dynamic link you don't have to make any changes through the firebase console or in the codebase to handle the link on app launch

Yeah @nb9960 i saw your pr i got my doubt cleared so i can work on this part right @himanshusharma89 ?

@himanshusharma89
Copy link
Owner Author

@anotherwebguy As I mentioned earlier one person can work on a single issue at a time.

@anotherwebguy
Copy link
Contributor

anotherwebguy commented Mar 10, 2021

@anotherwebguy As I mentioned earlier one person can work on a single issue at a time.

Hey @himanshusharma89 but at the moment i am not assigned any issue in relic_bazar project.plz assign me this issue
I means my work in issue #39 was only to make the screen responsive which i already did and u merged that pr
So at present i am not assigned any issue

@himanshusharma89
Copy link
Owner Author

@anotherwebguy The issue is still not resolved but I'll assign new issues to you. By responsive it means we don't have to add a custom height for the widget instead use the Flex.

@anotherwebguy
Copy link
Contributor

@anotherwebguy The issue is still not resolved but I'll assign new issues to you. By responsive it means we don't have to add a custom height for the widget instead use the Flex.

Okay sir i'll do that

@anotherwebguy
Copy link
Contributor

@anotherwebguy The issue is still not resolved but I'll assign new issues to you. By responsive it means we don't have to add a custom height for the widget instead use the Flex.

So now can u assign me this issue as i've now made an pr for issue #39

@himanshusharma89
Copy link
Owner Author

So now can u assign me this issue as i've now made an pr for issue #39

This issue will be taken care of later on as it is dependant upon the Dynamic Links. And we need to create the UI first.

@subhangi2731
Copy link

@himanshusharma89 please assign this issue to me

@himanshusharma89 himanshusharma89 added hacktoberfest and removed GSSOC21 Issues created for GSSOC'21 Level3 hard gssoc issue labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants