Skip to content

Conversation

@richardwu
Copy link

@richardwu richardwu commented Mar 5, 2020

Description

Division was used incorrectly instead of modulus for checking if a partial minibatch exists.

Motivation and Context

Same as description.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have ensured pytest and pytype both pass (by running make pytest and make type).

@araffin
Copy link
Collaborator

araffin commented Mar 6, 2020

Hello,
thanks for the PR. Please don't delete item from the PR check-list next time ;)
(and don't forget to add your username at the bottom of the changelog)

@richardwu
Copy link
Author

Apologies for deleting the checkbox: I've added it back in :)

Copy link
Collaborator

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit ac46c37 into hill-a:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants