enh(shell) allow period in prompt match (#4244) #4245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a "." to match in the prompt section of shell/console examples.
joshgoebel
reviewed
Apr 24, 2025
Comment on lines
-1
to
+3
| pao-sw-a04-40(config)# interface range ethernet 1/1/1-1/1/9 | ||
| pao-sw-a04-42(conf-range-eth1/1/1-1/1/9)# switchport trunk allowed vlan 1102 | ||
| pao-sw-a04-42(conf-range-eth1/1/1-1/1/9)# show configuration | ||
| pao.sw.a04-40(config)# interface range ethernet 1/1/1-1/1/9 | ||
| pao.sw.a04-42(conf-range-eth1/1/1-1/1/9)# switchport trunk allowed vlan 1102 | ||
| pao.sw.a04-42(conf-range-eth1/1/1-1/1/9)# show configuration |
There was a problem hiding this comment.
Why would we remove the old tests? The goal here is to support both, yes? If so lets put the old tests back so that we're testing both formats.
Otherwise seems reasonable. Thanks!
There was a problem hiding this comment.
Since this replaces a “-“ with a “.” but retains other “-“ it feels to me this covers both cases OK. If you feel strongly I can make another separate test.
There was a problem hiding this comment.
Yes, lets keep the old tests and just add the 3 new lines of tests right after. That'd be perfect!
Yang062
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a "." to match in the prompt section of shell/console examples.
Changes
Checklist
CHANGES.md