fix(ex) #4238 and add test #4241
Conversation
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +28 B View Changes
|
| @@ -0,0 +1,2 @@ | |||
| defguardp apostrophe?(c) when c == ?' | |||
| defguardp upper?(c) when (c >= ?A and c <= ?Z) | |||
There was a problem hiding this comment.
What are ?A and ?Z then? Are they not also char literals?
There was a problem hiding this comment.
They are, but char literals can be any character. To keep the change small and the matching efficient, I just targeted the most problematic case (at least for now). If you want to leave them absolutely consistent with other char literals, disabling highlighting ?' (I guess with className: null?) could also work.
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +27 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +31 B View Changes
|
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +33 B View Changes
|
|
@joshgoebel Any idea when you'll cut a release on this? I'd like to get an updated version on Exercism at some point. No pressure though if it's not a good time etc! |
Adds support for the
?'char literal and the missingdefguardpkeyword.Resolves #4238 — see more detail there.
Changes
?', that otherwise breaks formatting significantly by turning on comment mode.defguardpkeyword, which happened to be missing.Checklist
CHANGES.md