fix(python) Fix recognition of numeric literals followed by keywords without whitespace #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
gh-2985-keyword-after-numeric-literal
branch
from
5091bd6
to
2a2dac1
Compare
joshgoebel
reviewed
Oct 19, 2021
joshgoebel
reviewed
Oct 19, 2021
| // https://docs.python.org/3.9/reference/lexical_analysis.html#whitespace-between-tokens | ||
| // We deviate slightly, requiring a word boundary or a keyword | ||
| // to avoid accidentally recognizing *prefixes* (e.g., `0` in `0x41` or `08` or `0__1`) | ||
| const lookahead = `\\b|${RESERVED_WORDS.join('|')}`; |
There was a problem hiding this comment.
Well if that isn't rather clever. :)
joshgoebel
approved these changes
Oct 22, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2985
Changes
Allow numeric literals to be followed by a word boundary OR keyword.
Checklist
CHANGES.md