enh(scala) add using soft keyword
#3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-using-soft-keyword
branch
2 times, most recently
from
bfa8406
to
c6f7de9
Compare
joshgoebel
reviewed
Sep 7, 2021
joshgoebel
reviewed
Sep 7, 2021
joshgoebel
requested changes
Sep 7, 2021
nicolasstucki
force-pushed
the
add-using-soft-keyword
branch
2 times, most recently
from
36cfcbd
to
a71c972
Compare
joshgoebel
reviewed
Sep 10, 2021
`using` is a keyword if it appears at the start of a parameter or argument list. See https://docs.scala-lang.org/scala3/reference/soft-modifier.html Based on https://github.com/scala/vscode-scala-syntax/blob/57e0829cd46980699570101a68c320a20330d36c/src/typescript/Scala.tmLanguage.ts#L504
nicolasstucki
force-pushed
the
add-using-soft-keyword
branch
from
a71c972
to
e9b718c
Compare
joshgoebel
approved these changes
Sep 10, 2021
|
@nicolasstucki Anything else or is scala perfect now? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
usingis a keyword if it appears at the start of a parameter or argument list.See https://docs.scala-lang.org/scala3/reference/soft-modifier.html
Based on https://github.com/scala/vscode-scala-syntax/blob/57e0829cd46980699570101a68c320a20330d36c/src/typescript/Scala.tmLanguage.ts#L504
Checklist
CHANGES.md