Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(c,cpp) highlight type modifiers as type #3316

Merged
merged 4 commits into from
Aug 30, 2021
Merged

enh(c,cpp) highlight type modifiers as type #3316

merged 4 commits into from
Aug 30, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Aug 28, 2021 •
edited
Loading

Resolves #3313

Changes

Adds the following to be highlighted as types:

  • static
  • const
  • unsigned
  • signed

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel mentioned this pull request Aug 28, 2021
Closed
2 tasks
@joshgoebel joshgoebel requested a review from allejo August 28, 2021 15:28
allejo
allejo approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I guess technically you'd usually see these as modifiers to types. I have no objections to organizing them like this for that reason.

@joshgoebel joshgoebel merged commit 1fcf615 into highlightjs:main Aug 30, 2021
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@Jimimaku Jimimaku mentioned this pull request Jul 28, 2024
Closed
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 18, 2024
Open
@soyabn09 soyabn09 mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgoebel @allejo