(CSS) hex alpha color

[ierehon1905]

highlight.js/src/languages/lib/css-shared.js

Line 10 in 7cb4e3d

begin: '#([a-fA-F0-9]{6}|[a-fA-F0-9]{3})'

Hello, thank you for your hard work. I noticed some issues with highlighting in css colors, specifically in those with alpha channel. According to MDN hex representation both short and long have optional alpha channel.

This breaks the highlighting giving the last symbols another color

[joshgoebel]

Ah should probably be {3,4} and {6,8} then... would you be willing to work on a PR?

[taufik-nurrohman]

@ierehon1905 @joshgoebel

'#([0-9a-fA-F]{1,2}){3,4}'

Matches:

• #cde
• #cdef
• #ccddee
• #ccddeeff

[joshgoebel]

Nice. If the security checker doesn't flag it because it can be resolved multiple ways... though the numbers might be low enough that it won't.

[ierehon1905]

#([0-9a-fA-F]{1,2}){3,4}

It seems like #f1f1f10 passes too, but it is not a valid color. Is this intended ?

[ierehon1905]

I have come up with a less pretty pattern.

#(([0-9a-fA-F]{3,4})|(([0-9a-fA-F]{2}){3,4}))\b

regex 101 link

[ierehon1905]

Created a pull request #3362