Improve malformed file handling for OpenSSH Private Keys #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
============================================
+ Coverage 68.36% 68.39% +0.02%
- Complexity 1397 1399 +2
============================================
Files 207 207
Lines 7423 7430 +7
Branches 629 631 +2
============================================
+ Hits 5075 5082 +7
Misses 2014 2014
Partials 334 334
|
hierynomus
approved these changes
Oct 9, 2023
Owner
|
Thanks @exceptionfactory ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves malformed file handling for OpenSSH Private Keys, resolving a potential
NullPointerExceptiondescribed in issue #897.The improvement adds standard
nullchecking while reading lines from the inputBufferedReader, and also throws anIOExceptionwith a message indicating the absence of the requiredEND OPENSSH PRIVATE KEYfooter.Changes also include new test cases for invalid header and footer lines.