Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cipher chacha20-poly1305@openssh.com #682

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Support cipher chacha20-poly1305@openssh.com #682

merged 2 commits into from
Apr 20, 2021

Conversation

hpoettker
Copy link
Contributor

Resolves #629.

@hpoettker hpoettker requested a review from hierynomus as a code owner April 19, 2021 21:30
vladimirlagunov
vladimirlagunov reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@vladimirlagunov vladimirlagunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very important feature! Thanks for implementing it!

src/main/java/com/hierynomus/sshj/transport/cipher/ChachaPolyCipher.java Outdated Show resolved Hide resolved
@hierynomus hierynomus merged commit 16db036 into hierynomus:master Apr 20, 2021
@hierynomus
Copy link
Owner

Thanks for the PR, I fixed the comment @vladimirlagunov had, and merged it.

@hpoettker hpoettker deleted the chacha branch April 20, 2021 16:16
@dkocher
Copy link
Contributor

dkocher commented Apr 27, 2021

Wouldn't want you add this to the default configuration in DefaultConfig?

@hierynomus
Copy link
Owner

Thanks @dkocher, indeed, fixed on master!

@TranceLove TranceLove mentioned this pull request May 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirlagunov vladimirlagunov vladimirlagunov left review comments

@hierynomus hierynomus hierynomus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support for chacha20-poly1305@openssh.com
4 participants
@hpoettker @hierynomus @dkocher @vladimirlagunov