Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add custom header definitions #132

Merged
merged 8 commits into from
Mar 21, 2017

Conversation

arnarpall
Copy link
Contributor

I added a way to define custom header definitions through the gradle dsl

Adding header definitions can be done throught he license extension
This more or less fits with the way it was done in the maven plugin
http://code.mycila.com/license-maven-plugin/#changing-header-style-definitions

license {
    headerDefinitions {
        custom_definition {
          firstLine = "//"
          endLine   = "//"
          firstLineDetectionPattern = "//"
          lastLineDetectionPattern  = "//"
          allowBlankLines = false
          skipLinePattern = "//"
          isMultiline = false
        }
    }
}

@hierynomus
Copy link
Owner

Wow, great thanks!
On first glance, only some styling issues. In some places you put the open-curly on a new line and other places you (correctly) didn't. If you could reformat that to match the style of the rest of the project, I think we're good to go!

@arnarpall
Copy link
Contributor Author

No problem, i'll get that fixed

@hierynomus hierynomus merged commit 0e6514c into hierynomus:master Mar 21, 2017
@hierynomus
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants