feat: Add Acceptance Criteria to Good First Issue Template (#997)#998
Conversation
|
[commit-verification-bot] To achieve verified status, please read: Remember, you require a GPG key and each commit must be signed with: Thank you for contributing! From the Hiero Python SDK Team |
There was a problem hiding this comment.
Pull request overview
This pull request adds an Acceptance Criteria section to the Good First Issue template to help new contributors understand the requirements for having their PRs merged, thereby reducing friction for first-time contributors.
Key Changes:
- Added a new "Acceptance Criteria" section to the Good First Issue YAML template with a checklist of merge requirements
- Updated CHANGELOG.md to document this enhancement under the Unreleased section
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/ISSUE_TEMPLATE/01_good_first_issue.yml |
Added new acceptance criteria textarea field with a checklist covering changelog entries, signed commits, test passing, and issue resolution requirements |
CHANGELOG.md |
Added changelog entry documenting the new Acceptance Criteria section in the Good First Issue template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
As you have some changes to make, i've converted this to draft please check 'Ready to review' when its ready to review again 👍 This will reduce spam |
adityashirsatrao007
force-pushed
the
feat/add-acceptance-criteria-template
branch
2 times, most recently
from
3dd5d7e to
55bfad6
Compare
There was a problem hiding this comment.
Hi @adityashirsatrao007 great! last final stretch!
Could you revert all your changelog changes, one easy way is to copy and paste in the CODE of the changelog from main.
After that, layer on just your desired change of line 18, then recommit
Right now you actually changed 3 lines which often happesn because your branch is not in sync with the upstream
https://github.com/hiero-ledger/hiero-sdk-python/pull/998/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
adityashirsatrao007
force-pushed
the
feat/add-acceptance-criteria-template
branch
2 times, most recently
from
cf20421 to
e5c685b
Compare
exploreriii
left a comment
exploreriii
left a comment
There was a problem hiding this comment.
Please review
I see the same issue
https://github.com/hiero-ledger/hiero-sdk-python/pull/998/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
its not a major issue, but it is not right - it changes the history, so those lines are now attributed to you on the changelog.
I would recommend deleting line 10, and in line 13 swtich back to the orginal formatting of the str method.
adityashirsatrao007
force-pushed
the
feat/add-acceptance-criteria-template
branch
3 times, most recently
from
dfe96a4 to
037d07d
Compare
…997) Signed-off-by: Aditya <adityashirsatrao007@gmail.com> Signed-off-by: Aditya Shirsat <adityashirsatrao007@gmail.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: Aditya Shirsat <adityashirsatrao007@gmail.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: Aditya Shirsat <adityashirsatrao007@gmail.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
…a entry Signed-off-by: adityashirsatrao007 <adityashirsatrao007@users.noreply.github.com> Signed-off-by: adityashirsatrao007 <adityashirsatrao007@gmail.com>
adityashirsatrao007
force-pushed
the
feat/add-acceptance-criteria-template
branch
from
037d07d to
8c1486f
Compare
exploreriii
left a comment
exploreriii
left a comment
There was a problem hiding this comment.
I tested this on a fork and it works! Thank you! Nice work
Closes #997
Changes
Purpose
To guide new contributors on the requirements for having their PRs merged, reducing friction for first-time contributors.