Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to analytic fields in magneticfieldclasses.py #391

Open
smoniewski opened this issue Feb 6, 2024 · 0 comments
Open

Enhancements to analytic fields in magneticfieldclasses.py #391

smoniewski opened this issue Feb 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@smoniewski
Copy link
Contributor

While adding dofs to CircularCoil in #377, a couple points were raised. I thought they were out of the scope of the pull request, so I am repeating them here.

  1. Updated CircularCoil class to alllow for dofs #377 (comment) > what about the other magnetic fields in this file (ToroidalField, PoloidalField, DipoleField, etc)? they don't have this added support. Not saying that we need to, but just something that I noticed.
  2. Updated CircularCoil class to alllow for dofs #377 (comment) > this field is tied to a specific coil, but that coil is not a geometry object. So this coil will not work for any of the regular curve objectives. Perhaps we should have a CircularCoil curve object that gets its field from CircularCoilField.
@smoniewski smoniewski added the enhancement New feature or request label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant