[wip/4.2] Implemented Reactive versions of PostAction, PreAction and JdbcSelectWithActions #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibernate-github-bot
bot
changed the title
hibernate-github-bot
bot
added
the
wip/4.2
DavideD
reviewed
Nov 4, 2025
hibernate-reactive-core/src/test/java/org/hibernate/reactive/FindByIdWithLockTest.java
Outdated
Show resolved
Hide resolved
dreab8
force-pushed
the
issue#2651_4.2
branch
4 times, most recently
from
229542e to
a48c3b8
Compare
DavideD
force-pushed
the
wip/4.2
branch
2 times, most recently
from
b0fdbef to
b543eb0
Compare
DavideD
added
the
waiting
Member
|
We need to wait for the next ORM 7.2 release |
DavideD
requested changes
Nov 10, 2025
...ava/org/hibernate/reactive/sql/exec/internal/lock/ReactiveConnectionLockTimeoutStrategy.java
Outdated
Show resolved
Hide resolved
...te-reactive-core/src/main/java/org/hibernate/reactive/sql/exec/internal/lock/LockHelper.java
Outdated
Show resolved
Hide resolved
...nate/reactive/sql/exec/internal/lock/ReactiveCockroachConnectionLockTimeoutStrategyImpl.java
Outdated
Show resolved
Hide resolved
...nate/reactive/sql/exec/internal/lock/ReactiveCockroachConnectionLockTimeoutStrategyImpl.java
Outdated
Show resolved
Hide resolved
...tive-core/src/main/java/org/hibernate/reactive/sql/exec/internal/lock/ReactiveTableLock.java
Outdated
Show resolved
Hide resolved
| ReactiveListResultsConsumer.UniqueSemantic.ALLOW | ||
| ).thenCompose( results -> { | ||
| if ( isEmpty( results ) ) { | ||
| throw new AssertionFailure( "Expecting results" ); |
Member
There was a problem hiding this comment.
Can't we add anything else to the error message? What should have the query returned? Something related to a lock I imagine.
...tive-core/src/main/java/org/hibernate/reactive/sql/exec/internal/lock/ReactiveTableLock.java
Outdated
Show resolved
Hide resolved
...tive-core/src/main/java/org/hibernate/reactive/sql/exec/internal/lock/ReactiveTableLock.java
Show resolved
Hide resolved
...tive-core/src/main/java/org/hibernate/reactive/sql/exec/internal/lock/ReactiveTableLock.java
Outdated
Show resolved
Hide resolved
Member
|
I upgraded main to ORM 7.2.0.CR2, could you rebase it there, please? |
Member
Just in case, you don't have to create a new PR, you can just change the base branch in this one |
…ction` and `JdbcSelectWithActions`
dreab8
force-pushed
the
issue#2651_4.2
branch
from
a48c3b8 to
b8e1b34
Compare
…teException to Log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2651
The PR implements the Reactive version of
JdbcSelectWithActionsand of the newPostActionandPreAction(ReactiveLockTimeoutHandlerandReactiveLockTimeoutHandler).The PR does not implement the Reactive version of
CollectionLockingActionbut in order to use it a Reactive version oforg.hibernate.query.SelectionQuery#setLockScope(Locking.Scope lockScope);method need to be added.