Skip to content

Commit 22c213e

Browse files
committed
[912] SchemaMigrator/SchemaValidator support for MS SQL Server
Change test arguments that are inconsistent with their function
1 parent cb4e5a3 commit 22c213e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

hibernate-reactive-core/src/test/java/org/hibernate/reactive/SchemaUpdateSqlServerTestBase.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,22 +99,22 @@ public void after(TestContext context) {
9999

100100
@Test
101101
public void testValidationSucceed(TestContext context) {
102-
Configuration createHbm2ddlConf = constructConfiguration( "validate" );
103-
createHbm2ddlConf.addAnnotatedClass( ASimpleFirst.class );
104-
createHbm2ddlConf.addAnnotatedClass( AOther.class );
102+
Configuration configuration = constructConfiguration( "validate" );
103+
configuration.addAnnotatedClass( ASimpleFirst.class );
104+
configuration.addAnnotatedClass( AOther.class );
105105

106-
test( context, setupSessionFactory( createHbm2ddlConf ) );
106+
test( context, setupSessionFactory( configuration ) );
107107
}
108108

109109
//TODO: I'm just checking that the validation fails because the table is missing, but we need more tests to check that
110110
// it fails for other scenarios: missing column, wrong type (?) and so on. (I don't know exactly what cases `validate`
111111
// actually checks).
112112
@Test
113113
public void testValidationFails(TestContext context) {
114-
Configuration createHbm2ddlConf = constructConfiguration( "validate" );
115-
createHbm2ddlConf.addAnnotatedClass( AAnother.class );
114+
Configuration configuration = constructConfiguration( "validate" );
115+
configuration.addAnnotatedClass( AAnother.class );
116116

117-
test( context, setupSessionFactory( createHbm2ddlConf )
117+
test( context, setupSessionFactory( configuration )
118118
.handle( (unused, throwable) -> {
119119
context.assertNotNull( throwable );
120120
context.assertEquals( throwable.getClass(), SchemaManagementException.class );

0 commit comments

Comments
 (0)