Skip to content

HHH-17355 Smoothen rough edges with array functions #7480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 6, 2023
Merged

HHH-17355 Smoothen rough edges with array functions #7480

merged 19 commits into from
Nov 6, 2023

Conversation

beikov
Copy link
Member

@beikov beikov commented Oct 26, 2023 •
edited by hibernate-github-bot bot
Loading

@beikov beikov force-pushed the HHH-17355 branch 2 times, most recently from 23ee740 to ec0b6e5 Compare October 31, 2023 18:01
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 31, 2023 •
edited
Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

beikov added 19 commits November 6, 2023 16:42
@beikov
HHH-17355 Skip ArraySliceTest on CockroachDB as slicing is not yet im…
ed59810 
…plemented on that database
@beikov
HHH-17355 Rename array_contains_any to array_overlaps
e60fd0c
@beikov
HHH-17355 Unify array_contains and array_contains_all as well as depr…
93cf0ef 
…ecate FunctionRenderingSupport in favor of new FunctionRenderer contract
@beikov
HHH-17355 Small Return type resolver method cleanup and fix firstNonN…
a61d9ea 
…ull resolver
@beikov
HHH-17355 Support binding single element value for basic plural param…
a5b5b27 
…eter types
@beikov
HHH-17355 Support double-pipe operator for array concatenation
827abae
@beikov
HHH-17355 Add array functions to NodeBuilder
18a552f
@beikov
HHH-17355 Add array functions for collection types to NodeBuilder
d3de36a
@beikov
HHH-17355 Add array_agg documentation and add it to NodeBuilder
1c0a821
@beikov
HHH-17355 Add array_trim function
92b3b0c
@beikov
HHH-17355 Add array_trim functions to NodeBuilder
ff975b0
@beikov
HHH-17355 Add array_fill function
a90d02d
@beikov
HHH-17355 Add array_fill function to NodeBuilder
1297bb3
@beikov
HHH-17355 Add array_positions and array_positions_list functions
103eb0e
@beikov
HHH-17355 Add array_positions and array_positions_list to NodeBuilder
e8cb07b
@beikov
HHH-17355 Add array_to_string function
357bfa8
@beikov
HHH-17355 Add array_to_string to NodeBuilder
8478bc1
@beikov
HHH-17355 Test array functions with NodeBuilder
886b63e
@beikov
HHH-17355 Smoothen some rough edges with parameter typing and PG12 su…
7f6306d 
…pport
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 6, 2023
View reviewed changes
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getCastTypeName( type, Size.nil(), typeConfiguration );
}

public static String getCastTypeName(ReturnableType<?> type, Size size, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](1), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
}
}

public static String getCastTypeName(ReturnableType<?> type, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](1), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getCastTypeName( type, Size.nil(), typeConfiguration );
}

public static String getCastTypeName(JdbcMappingContainer type, Size size, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](1), since dispatch depends on static types. Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](2), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getCastTypeName( (JdbcMappingContainer) type, size, typeConfiguration );
}

public static String getCastTypeName(JdbcMappingContainer type, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](1), since dispatch depends on static types. Method DdlTypeHelper.getCastTypeName(..) could be confused with overloaded method [getCastTypeName](2), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getTypeName( type, Size.nil(), typeConfiguration );
}

public static String getTypeName(ReturnableType<?> type, Size size, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](1), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
}
}

public static String getCastTypeName(JdbcMappingContainer type, SqlAstTranslator<?> walker) {
public static String getTypeName(ReturnableType<?> type, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](1), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getTypeName( type, Size.nil(), typeConfiguration );
}

public static String getTypeName(JdbcMappingContainer type, Size size, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](1), since dispatch depends on static types. Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](2), since dispatch depends on static types.
hibernate-core/src/main/java/org/hibernate/dialect/function/array/DdlTypeHelper.java
return getTypeName( (JdbcMappingContainer) type, size, typeConfiguration );
}

public static String getTypeName(JdbcMappingContainer type, TypeConfiguration typeConfiguration) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods

Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](1), since dispatch depends on static types. Method DdlTypeHelper.getTypeName(..) could be confused with overloaded method [getTypeName](2), since dispatch depends on static types.
@beikov beikov merged commit c700dcd into hibernate:main Nov 6, 2023
@beikov beikov deleted the HHH-17355 branch May 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beikov