proposed fixes to Query API #4516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebersole
reviewed
Dec 27, 2021
I hate doing this but it's necessary since Query is often used as a raw type, and the wildcards result in additional compiler warnings at the usage site Also clean up some other warnings I encountered in this code
- and add a second new overload - tolerate non-entity classes as arguments to these methods - the overloads accept a result class, and return a typed Query<R>
gavinking
force-pushed
the
no-wildcards-in-query
branch
from
4b52f6f to
ce1697f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this work is to alleviate the problem of warning in the client program resulting from invocations of raw
Querys returned by HibernateSessionmethods.This is a difficult problem due to the requirements of backward compatibility with ancient versions of Hibernate, and due to the inheritance from
EntityManagerwhich still uses raw types.As discussed, I have:
@SuppressWarnings("rawtypes")to wildcards<?>in methods ofQuery.@DeprecatedcreateXxxxQuery()methods which accept no class.createNativeQuery()methods with additional overloads, and the ability to accept a non-entity result class.This solution is imperfect, but it's at least an improvement.