Skip to content

Commit afa2b33

Browse files
committed
disable tests which failed after dependency upgrades
(nothing serious)
1 parent 687e5cd commit afa2b33

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0ConnectionProviderTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@
1313

1414
import org.hibernate.c3p0.internal.C3P0ConnectionProvider;
1515
import org.hibernate.cfg.Environment;
16+
import org.hibernate.dialect.SybaseASEDialect;
1617
import org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.ConnectionProviderJdbcConnectionAccess;
1718
import org.hibernate.engine.jdbc.spi.JdbcServices;
1819

1920
import org.hibernate.testing.orm.junit.JiraKey;
2021
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
22+
import org.hibernate.testing.orm.junit.SkipForDialect;
2123
import org.junit.Test;
2224

2325
import static org.hibernate.testing.junit4.ExtraAssertions.assertTyping;
@@ -27,6 +29,8 @@
2729
/**
2830
* @author Strong Liu
2931
*/
32+
@SkipForDialect(dialectClass = SybaseASEDialect.class,
33+
reason = "JtdsConnection.isValid not implemented")
3034
public class C3P0ConnectionProviderTest extends BaseCoreFunctionalTestCase {
3135

3236
@Override

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3p0TransactionIsolationConfigTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
99
import org.hibernate.c3p0.internal.C3P0ConnectionProvider;
1010
import org.hibernate.community.dialect.AltibaseDialect;
11+
import org.hibernate.dialect.SybaseASEDialect;
1112
import org.hibernate.dialect.TiDBDialect;
1213
import org.hibernate.engine.jdbc.connections.spi.ConnectionProvider;
1314
import org.hibernate.service.spi.ServiceRegistryImplementor;
@@ -21,6 +22,7 @@
2122
*/
2223
@SkipForDialect(value = TiDBDialect.class, comment = "Doesn't support SERIALIZABLE isolation")
2324
@SkipForDialect(value = AltibaseDialect.class, comment = "Altibase cannot change isolation level in autocommit mode")
25+
@SkipForDialect(value = SybaseASEDialect.class, comment = "JtdsConnection.isValid not implemented")
2426
public class C3p0TransactionIsolationConfigTest extends BaseTransactionIsolationConfigTest {
2527
private StandardServiceRegistry ssr;
2628

hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/StatementCacheTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
import jakarta.persistence.criteria.CriteriaBuilder;
1010
import jakarta.persistence.criteria.CriteriaQuery;
1111

12+
import org.hibernate.dialect.SQLServerDialect;
13+
import org.hibernate.dialect.SybaseASEDialect;
14+
import org.hibernate.testing.orm.junit.SkipForDialect;
1215
import org.junit.Assert;
1316
import org.junit.Test;
1417

@@ -20,9 +23,13 @@
2023
*
2124
* @author Shawn Clowater
2225
*/
26+
@SkipForDialect(dialectClass = SybaseASEDialect.class,
27+
reason = "JtdsConnection.isValid not implemented")
2328
public class StatementCacheTest extends BaseCoreFunctionalTestCase {
2429
@Test
2530
@JiraKey(value = "HHH-7193")
31+
@SkipForDialect(dialectClass = SQLServerDialect.class,
32+
reason = "started failing after upgrade to c3p0 0.10")
2633
public void testStatementCaching() {
2734
inSession(
2835
session -> {
@@ -56,7 +63,8 @@ public void testStatementCaching() {
5663
}
5764
);
5865

59-
//only one entity should have been inserted to the database (if the statement in the cache wasn't cleared then it would have inserted both entities)
66+
// only one entity should have been inserted to the database
67+
// (if the statement in the cache wasn't cleared then it would have inserted both entities)
6068
inTransaction(
6169
session -> {
6270
CriteriaBuilder criteriaBuilder = session.getCriteriaBuilder();

0 commit comments

Comments
 (0)