skip some tests on Informix

Author: gavinking

hibernate-core/src/test/java/org/hibernate/orm/test/constraint/ConstraintInterpretationTest2.java

@@ -27,6 +27,7 @@
 import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
 import org.hibernate.testing.orm.junit.Jpa;
 import org.hibernate.testing.orm.junit.RequiresDialect;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -101,6 +102,9 @@ public class ConstraintInterpretationTest2 {
 			}
 		} );
 	}
+
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "multi-column check constraints must be created using 'alter table', and we don't have a StandardCheckConstraintExporter")
 	@Test void testCheck(EntityManagerFactoryScope scope) {
 		scope.inTransaction( em -> {
 			try {

hibernate-core/src/test/java/org/hibernate/orm/test/datasource/DataSourceTest.java

@@ -8,7 +8,9 @@
 import jakarta.persistence.Id;
 import org.hibernate.cfg.Environment;
 import org.hibernate.cfg.JdbcSettings;
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.DB2Dialect;
+import org.hibernate.dialect.Dialect;
 import org.hibernate.dialect.OracleDialect;
 import org.hibernate.internal.log.ConnectionInfoLogger;
 import org.hibernate.testing.logger.LogInspectionHelper;
@@ -35,7 +37,9 @@ void test(EntityManagerFactoryScope scope) {
 		LogInspectionHelper.registerListener( listener, ConnectionInfoLogger.INSTANCE );
 		scope.getEntityManagerFactory();
 		LogInspectionHelper.clearAllListeners( ConnectionInfoLogger.INSTANCE );
-		assertTrue( scope.getDialect() instanceof OracleDialect dialect && dialect.isAutonomous()
+		Dialect dialect = scope.getDialect();
+		assertTrue( dialect instanceof OracleDialect od && od.isAutonomous()
+					|| dialect instanceof InformixDialect // Informix metadata does not include the URL
 					|| listener.seen );
 	}
 

hibernate-core/src/test/java/org/hibernate/orm/test/hql/FunctionNameAsColumnTest.java

@@ -15,11 +15,12 @@
 import org.hibernate.Session;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.cfg.Environment;
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.PostgresPlusDialect;
 import org.hibernate.dialect.SybaseASEDialect;
 
-import org.hibernate.testing.SkipForDialect;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.After;
 import org.junit.Assume;
 import org.junit.Test;
@@ -33,8 +34,9 @@
  *
  * @author Gail Badner
  */
-@SkipForDialect(value = SybaseASEDialect.class, jiraKey = "HHH-6426")
-@SkipForDialect(value = PostgresPlusDialect.class, comment = "Almost all of the tests result in 'ambiguous column' errors.")
+@SkipForDialect(dialectClass = SybaseASEDialect.class, reason = "HHH-6426")
+@SkipForDialect(dialectClass = PostgresPlusDialect.class,
+		reason = "Almost all of the tests result in 'ambiguous column' errors.")
 public class FunctionNameAsColumnTest extends BaseCoreFunctionalTestCase {
 	@Override
 	protected String getBaseForMappings() {
@@ -200,6 +202,7 @@ public void testGetMultiColumnSameNameAsArgFunctionCriteria() {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class, reason = "Ambiguous column")
 	public void testGetMultiColumnSameNameAsNoArgFunctionHQL() {
 		Assume.assumeFalse(
 				"current_date requires () but test is for noarg function that does not require ()",
@@ -254,6 +257,7 @@ public void testGetMultiColumnSameNameAsNoArgFunctionHQL() {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class, reason = "Ambiguous column")
 	public void testGetMultiColumnSameNameAsNoArgFunctionCriteria() {
 		Assume.assumeFalse(
 				"current_date requires () but test is for noarg function that does not require ()",

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/criteria/CoalesceTest.java

@@ -7,11 +7,13 @@
 import java.math.BigDecimal;
 import java.util.List;
 
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
 import org.hibernate.testing.orm.junit.Jira;
 import org.hibernate.testing.orm.junit.Jpa;
 
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -42,6 +44,8 @@
 @JiraKey( value = "HHH-15291")
 public class CoalesceTest {
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support parameters in COALESCE" )
 	public void hhh15291JPQL1Test(EntityManagerFactoryScope scope) {
 		scope.inEntityManager(
 				entityManager -> {
@@ -57,6 +61,8 @@ public void hhh15291JPQL1Test(EntityManagerFactoryScope scope) {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support parameters in COALESCE" )
 	public void hhh15291JPQL2Test(EntityManagerFactoryScope scope) {
 		scope.inEntityManager(
 				entityManager -> {
@@ -65,11 +71,14 @@ public void hhh15291JPQL2Test(EntityManagerFactoryScope scope) {
 							String.class
 					);
 					query2.setParameter( 1, "Sample" );
+					query2.getResultList();
 				}
 		);
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support parameters in COALESCE" )
 	public void hhh15291Criteria1Test(EntityManagerFactoryScope scope) {
 		scope.inEntityManager(
 				entityManager -> {
@@ -90,6 +99,8 @@ public void hhh15291Criteria1Test(EntityManagerFactoryScope scope) {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support parameters in COALESCE" )
 	public void hhh15291Criteria2Test(EntityManagerFactoryScope scope) {
 		scope.inEntityManager(
 				entityManager -> {

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/criteria/basic/ConcatTest.java

@@ -23,7 +23,7 @@
 import org.hibernate.testing.orm.junit.JiraKey;
 
 import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertThat;
+import static org.hamcrest.MatcherAssert.assertThat;
 
 /**
  * @author Andrea Boriero
@@ -58,7 +58,7 @@ public void setUp() {
 	}
 
 	@Test
-	public void testSelectCaseWithConcat() throws Exception {
+	public void testSelectCaseWithConcat() {
 		EntityManager entityManager = getOrCreateEntityManager();
 		entityManager.getTransaction().begin();
 		try {
@@ -91,7 +91,7 @@ public void testSelectCaseWithConcat() throws Exception {
 	}
 
 	@Test
-	public void testConcat() throws Exception {
+	public void testConcat() {
 		EntityManager entityManager = getOrCreateEntityManager();
 		entityManager.getTransaction().begin();
 		try {

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/generated/sql/ImmutableSqlGeneratedTest.java

@@ -8,6 +8,7 @@
 import jakarta.persistence.Id;
 import org.hibernate.annotations.Generated;
 import org.hibernate.annotations.Immutable;
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.dialect.SybaseASEDialect;
 import org.hibernate.generator.EventType;
 import org.hibernate.testing.orm.junit.DomainModel;
@@ -20,18 +21,19 @@
 import java.math.BigDecimal;
 import java.time.LocalDateTime;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNotSame;
 
 /**
  * @author Gavin King
  */
-@SuppressWarnings("JUnitMalformedDeclaration")
 @DomainModel(annotatedClasses = ImmutableSqlGeneratedTest.OrderLine.class)
 @SessionFactory
 @SkipForDialect(dialectClass = SybaseASEDialect.class,
 		reason = "The name 'current_timestamp' is illegal in this context. Only constants, constant expressions, or variables allowed here.")
+@SkipForDialect( dialectClass = InformixDialect.class,
+		reason = "No 'current_timestamp' function on Informix")
 public class ImmutableSqlGeneratedTest {
 
 	@Test
@@ -65,7 +67,7 @@ public void test(SessionFactoryScope scope) {
 			entity.status = "old";
 			session.flush();
 			assertNotNull( entity.updated );
-			assertFalse( previous == entity.updated );
+			assertNotSame( previous, entity.updated );
 		} );
 		scope.inTransaction( session -> {
 			OrderLine entity = session.createQuery("from WithDefault", OrderLine.class ).getSingleResult();

hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/LikeEscapeDefaultTest.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 
+import org.hibernate.community.dialect.InformixDialect;
 import org.hibernate.query.Query;
 
 import org.hibernate.testing.orm.domain.StandardDomainModel;
@@ -14,6 +15,7 @@
 import org.hibernate.testing.orm.junit.ServiceRegistry;
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -49,6 +51,8 @@ public void tearDown(SessionFactoryScope scope) {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support empty escape ''")
 	public void testDefaultEscapeBackslash(SessionFactoryScope scope) {
 		scope.inTransaction( session -> {
 			Query<BasicEntity> q = session.createQuery(
@@ -62,6 +66,8 @@ public void testDefaultEscapeBackslash(SessionFactoryScope scope) {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support empty escape ''")
 	public void testDefaultEscapeBackslashLiteral(SessionFactoryScope scope) {
 		scope.inTransaction( session -> {
 			Query<BasicEntity> q = session.createQuery(
@@ -75,6 +81,8 @@ public void testDefaultEscapeBackslashLiteral(SessionFactoryScope scope) {
 	}
 
 	@Test
+	@SkipForDialect(dialectClass = InformixDialect.class,
+			reason = "Informix does not support empty escape ''")
 	public void testDefaultEscapeNoResults(SessionFactoryScope scope) {
 		scope.inTransaction( session -> {
 			Query<BasicEntity> q = session.createQuery(

hibernate-core/src/test/java/org/hibernate/orm/test/schemaupdate/checkconstraint/table/TableCheckConstraintTest.java

@@ -31,7 +31,7 @@
 
 @BaseUnitTest
 @JiraKey("HHH-18054")
-@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsColumnCheck.class)
+@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsTableCheck.class)
 public class TableCheckConstraintTest {
 	static final String CONSTRAINTS = "NAME_COLUMN is not null";
 	static final String SECONDARY_TABLE_CONSTRAINTS = "SECOND_NAME is not null";
@@ -175,8 +175,8 @@ private static boolean tableCreationStatementContainsConstraints(
 			String[] fileContent,
 			String tableName,
 			String secondaryTableConstraints) {
-		for ( int i = 0; i < fileContent.length; i++ ) {
-			String statement = fileContent[i].toUpperCase( Locale.ROOT );
+		for ( String string : fileContent ) {
+			String statement = string.toUpperCase( Locale.ROOT );
 			if ( statement.contains( "CREATE TABLE " + tableName.toUpperCase( Locale.ROOT ) ) ) {
 				if ( statement.contains( secondaryTableConstraints.toUpperCase( Locale.ROOT ) ) ) {
 					return true;
@@ -186,10 +186,10 @@ private static boolean tableCreationStatementContainsConstraints(
 		return false;
 	}
 
-	private void createSchema(Class... annotatedClasses) {
+	private void createSchema(Class<?>... annotatedClasses) {
 		final MetadataSources metadataSources = new MetadataSources( ssr );
 
-		for ( Class c : annotatedClasses ) {
+		for ( Class<?> c : annotatedClasses ) {
 			metadataSources.addAnnotatedClass( c );
 		}
 		metadata = (MetadataImplementor) metadataSources.buildMetadata();