Fix parameter binding validation

Author: dreab8

hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureParamBindings.java

@@ -21,10 +21,16 @@
 import org.hibernate.query.spi.QueryParameterBindings;
 import org.hibernate.query.spi.QueryParameterImplementor;
 
+import org.jboss.logging.Logger;
+
+import jakarta.persistence.ParameterMode;
+
 /**
  * @author Steve Ebersole
  */
 public class ProcedureParamBindings implements QueryParameterBindings {
+	private static final Logger LOG = Logger.getLogger( QueryParameterBindings.class );
+
 	private final ProcedureParameterMetadataImpl parameterMetadata;
 	private final SessionFactoryImplementor sessionFactory;
 
@@ -91,19 +97,28 @@ public <P> ProcedureParameterBinding<P> getBinding(int position) {
 
 	@Override
 	public void validate() {
-//		parameterMetadata.visitRegistrations(
-//				queryParameter -> {
-//					final ProcedureParameterImplementor procParam = (ProcedureParameterImplementor) queryParameter;
-//					if ( procParam.getMode() == ParameterMode.IN
-//							|| procParam.getMode() == ParameterMode.INOUT ) {
-//						if ( !getBinding( procParam ).isBound() ) {
-//							// depending on "pass nulls" this might be ok...
-//							//  for now, just log a warning
-//						}
-//					}
-//				}
-//		);
-		throw new NotYetImplementedFor6Exception( getClass() );
+		parameterMetadata.visitRegistrations(
+				queryParameter -> {
+					final ProcedureParameterImplementor procParam = (ProcedureParameterImplementor) queryParameter;
+					if ( procParam.getMode() == ParameterMode.IN
+							|| procParam.getMode() == ParameterMode.INOUT ) {
+						if ( !getBinding( procParam ).isBound() ) {
+							// depending on "pass nulls" this might be ok...
+							//  for now, just log a warning
+							if ( procParam.getPosition() != null ) {
+								LOG.debugf(
+										"Procedure parameter at position %s is not bound",
+										procParam.getPosition()
+								);
+
+							}
+							else {
+								LOG.debugf( "Procedure parameter %s is not bound", procParam.getName() );
+							}
+						}
+					}
+				}
+		);
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/query/spi/QueryParameterBindingValidator.java

@@ -52,11 +52,11 @@ public void validate(
 		}
 
 		final Class<?> parameterJavaType;
+		final SqmExpressible<?> sqmExpressible = paramType.resolveExpressible( sessionFactory );
 		if ( paramType.getBindableJavaType() != null ) {
 			parameterJavaType = paramType.getBindableJavaType();
 		}
 		else {
-			final SqmExpressible<?> sqmExpressible = paramType.resolveExpressible( sessionFactory );
 			parameterJavaType = sqmExpressible.getBindableJavaType();
 		}
 
@@ -70,13 +70,26 @@ public void validate(
 			// 		NOTE : this can happen in Hibernate's notion of "parameter list" binding
 			// 		NOTE2 : the case of a collection value and an expected collection (if that can even happen)
 			//			will fall through to the main check.
-			validateCollectionValuedParameterBinding( parameterJavaType, (Collection<?>) bind, temporalPrecision );
+			validateCollectionValuedParameterBinding(
+					parameterJavaType,
+					(Collection<?>) bind,
+					temporalPrecision
+			);
 		}
 		else if ( bind.getClass().isArray() ) {
-			validateArrayValuedParameterBinding( parameterJavaType, bind, temporalPrecision );
+			validateArrayValuedParameterBinding(
+					parameterJavaType,
+					bind,
+					temporalPrecision
+			);
 		}
 		else {
-			if ( !isValidBindValue( parameterJavaType, bind, temporalPrecision ) ) {
+			if ( !isValidBindValue(
+					sqmExpressible.getExpressibleJavaType(),
+					parameterJavaType,
+					bind,
+					temporalPrecision
+			) ) {
 				throw new IllegalArgumentException(
 						String.format(
 								"Argument [%s] of type [%s] did not match parameter type [%s (%s)]",
@@ -113,7 +126,33 @@ private void validateCollectionValuedParameterBinding(
 		}
 	}
 
-	private static boolean isValidBindValue(Class<?> expectedType, Object value, TemporalType temporalType) {
+	private static boolean isValidBindValue(
+			JavaType<?> expectedJavaType,
+			Class<?> expectedType,
+			Object value,
+			TemporalType temporalType) {
+		if ( value == null ) {
+			return true;
+		}
+		else if ( expectedJavaType.isInstance( value ) ) {
+			return true;
+		}
+		else if ( temporalType != null ) {
+			final boolean parameterDeclarationIsTemporal = Date.class.isAssignableFrom( expectedType )
+					|| Calendar.class.isAssignableFrom( expectedType );
+			final boolean bindIsTemporal = value instanceof Date
+					|| value instanceof Calendar;
+
+			return parameterDeclarationIsTemporal && bindIsTemporal;
+		}
+
+		return false;
+	}
+
+	private static boolean isValidBindValue(
+			Class<?> expectedType,
+			Object value,
+			TemporalType temporalType) {
 		if ( expectedType.isPrimitive() ) {
 			if ( expectedType == boolean.class ) {
 				return value instanceof Boolean;

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampJavaType.java

@@ -205,6 +205,11 @@ protected <X> TemporalJavaType<X> forTimestampPrecision(TypeConfiguration typeCo
 		return (TemporalJavaType<X>) this;
 	}
 
+	@Override
+	protected <X> TemporalJavaType<X> forDatePrecision(TypeConfiguration typeConfiguration) {
+		return (TemporalJavaType<X>) JdbcDateJavaType.INSTANCE;
+	}
+
 	@Override
 	public int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) {
 		return dialect.getDefaultTimestampPrecision();