HHH-12795 Remove duplicate code from SessionImpl

SessionImpl.initQueryFromNamedDefinition calls its super implementation
AbstractSharedSessionContract.initQueryFromNamedDefinition, which
already does a lot of the work performed in
SessionImpl.initQueryFromNamedDefinition.
The only difference is that SessionImpl uses hints to set values on the
query, whereas AbstractSharedSessionContract uses direct calls to
setters. But that should produce the same result, since setHint() just
delegates to the setters.

Only one thing was done in SessionImpl but not in
AbstractSharedSessionContract: lock mode handling.
I left it in SessionImpl since moving it to the superclass would also
affect other subclasses such as StatelessSession or OGM sessions, and I
certainly don't want to change any behavior without further
investigation.

Author: yrodiere

hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java

@@ -3732,52 +3732,13 @@ public QueryImplementor createQuery(CriteriaDelete criteriaDelete) {
 	protected void initQueryFromNamedDefinition(Query query, NamedQueryDefinition namedQueryDefinition) {
 		super.initQueryFromNamedDefinition( query, namedQueryDefinition );
 
-		if ( namedQueryDefinition.isCacheable() ) {
-			query.setHint( QueryHints.HINT_CACHEABLE, true );
-			if ( namedQueryDefinition.getCacheRegion() != null ) {
-				query.setHint( QueryHints.HINT_CACHE_REGION, namedQueryDefinition.getCacheRegion() );
-			}
-		}
-
-		if ( namedQueryDefinition.getCacheMode() != null ) {
-			query.setHint( QueryHints.HINT_CACHE_MODE, namedQueryDefinition.getCacheMode() );
-		}
-
-		if ( namedQueryDefinition.isReadOnly() ) {
-			query.setHint( QueryHints.HINT_READONLY, true );
-		}
-
-		if ( namedQueryDefinition.getTimeout() != null ) {
-			query.setHint( QueryHints.SPEC_HINT_TIMEOUT, namedQueryDefinition.getTimeout() * 1000 );
-		}
-
-		if ( namedQueryDefinition.getFetchSize() != null ) {
-			query.setHint( QueryHints.HINT_FETCH_SIZE, namedQueryDefinition.getFetchSize() );
-		}
-
-		if ( namedQueryDefinition.getComment() != null ) {
-			query.setHint( QueryHints.HINT_COMMENT, namedQueryDefinition.getComment() );
-		}
-
-		if ( namedQueryDefinition.getFirstResult() != null ) {
-			query.setFirstResult( namedQueryDefinition.getFirstResult() );
-		}
-
-		if ( namedQueryDefinition.getMaxResults() != null ) {
-			query.setMaxResults( namedQueryDefinition.getMaxResults() );
-		}
-
 		if ( namedQueryDefinition.getLockOptions() != null ) {
 			if ( namedQueryDefinition.getLockOptions().getLockMode() != null ) {
 				query.setLockMode(
 						LockModeTypeHelper.getLockModeType( namedQueryDefinition.getLockOptions().getLockMode() )
 				);
 			}
 		}
-
-		if ( namedQueryDefinition.getFlushMode() != null ) {
-			query.setHibernateFlushMode( namedQueryDefinition.getFlushMode() );
-		}
 	}
 
 	@Override