Skip to content

Commit 01e8f02

Browse files
committed
try enabling these tests on Db2 🤞
1 parent 2c784b4 commit 01e8f02

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/datasource/DataSourceTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
1919
import org.hibernate.testing.orm.junit.Jpa;
2020
import org.hibernate.testing.orm.junit.Setting;
21-
import org.hibernate.testing.orm.junit.SkipForDialect;
2221
import org.jboss.logging.Logger;
2322
import org.junit.jupiter.api.Test;
2423

@@ -29,7 +28,6 @@
2928
@Jpa(annotatedClasses = DataSourceTest.TestEntity.class,
3029
integrationSettings = @Setting(name = JdbcSettings.CONNECTION_PROVIDER,
3130
value = "org.hibernate.orm.test.datasource.TestDataSourceConnectionProvider"))
32-
@SkipForDialect(dialectClass = DB2Dialect.class)
3331
public class DataSourceTest {
3432
@Test
3533
void test(EntityManagerFactoryScope scope) {
@@ -39,6 +37,7 @@ void test(EntityManagerFactoryScope scope) {
3937
LogInspectionHelper.clearAllListeners( ConnectionInfoLogger.INSTANCE );
4038
Dialect dialect = scope.getDialect();
4139
assertTrue( dialect instanceof OracleDialect od && od.isAutonomous()
40+
|| dialect instanceof DB2Dialect
4241
|| dialect instanceof InformixDialect // Informix metadata does not include the URL
4342
|| listener.seen );
4443
}

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/converted/converter/AndNationalizedTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@
1616
import org.hibernate.boot.registry.StandardServiceRegistry;
1717
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
1818
import org.hibernate.boot.spi.MetadataImplementor;
19-
import org.hibernate.dialect.DB2Dialect;
2019
import org.hibernate.dialect.Dialect;
2120
import org.hibernate.mapping.PersistentClass;
2221

23-
import org.hibernate.testing.SkipForDialect;
2422
import org.hibernate.testing.orm.junit.JiraKey;
2523
import org.hibernate.testing.junit4.BaseUnitTestCase;
2624
import org.hibernate.testing.util.ServiceRegistryUtil;
@@ -33,7 +31,7 @@
3331
*
3432
* @author Steve Ebersole
3533
*/
36-
@SkipForDialect(value = DB2Dialect.class, comment = "DB2 jdbc driver doesn't support setNString")
34+
//@SkipForDialect(value = DB2Dialect.class, comment = "DB2 jdbc driver doesn't support setNString")
3735
public class AndNationalizedTests extends BaseUnitTestCase {
3836
@Test
3937
@JiraKey( value = "HHH-9599")

hibernate-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaWindowFunctionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ public void testRank(SessionFactoryScope scope) {
255255
}
256256

257257
@Test
258-
@SkipForDialect(dialectClass = DB2Dialect.class, majorVersion = 10, reason = "No support for percent_rank and cume_dist functions")
258+
// @SkipForDialect(dialectClass = DB2Dialect.class, majorVersion = 10, reason = "No support for percent_rank and cume_dist functions")
259259
@SkipForDialect(dialectClass = AltibaseDialect.class, reason = "No support for percent_rank and cume_dist functions with over clause")
260260
public void testReusableWindow(SessionFactoryScope scope) {
261261
scope.inTransaction(

0 commit comments

Comments
 (0)