Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_instance_users_summary IndexError #2736

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

QSummerY
Copy link
Contributor

File "/opt/archery/sql/engines/mysql.py", line 401, in get_instance_users_summary
    "is_locked": db_user[3] if server_version >= (5, 7, 6) else None,
IndexError: tuple index out of range

mariadb < 10.4.2 时出现报错

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (ece8c33) to head (f06ea5c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
+ Coverage   77.22%   77.30%   +0.08%     
==========================================
  Files         119      119              
  Lines       16296    16316      +20     
==========================================
+ Hits        12584    12613      +29     
+ Misses       3712     3703       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本里能否区分mariadb 和mysql 分开判断,其他的变种当成 mysql判断

@LeoQuote LeoQuote merged commit e43ebc0 into hhyo:master Jul 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants