Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

对导航菜单进行优化 #2494

Merged
merged 2 commits into from
Feb 3, 2024
Merged

对导航菜单进行优化 #2494

merged 2 commits into from
Feb 3, 2024

Conversation

finovy
Copy link
Contributor

@finovy finovy commented Jan 29, 2024

  1. 对导航菜单进行优化
  2. 新增使用less用于编写css样式表
  3. 合并登录login.css到style.css

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bec5f4) 76.97% compared to head (f956c8c) 76.97%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files         115      115           
  Lines       15945    15945           
=======================================
  Hits        12274    12274           
  Misses       3671     3671

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LeoQuote
LeoQuote requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议不引入 less
如果引入的话，要在构建步骤中做css 文件的生成，并在开发手册，或目录的readme 区域说明开发时的构建方法。
不接受把 dist 文件夹提交到代码库中。

@finovy
Copy link
Contributor Author

finovy commented Jan 29, 2024

好的，已删除less

@finovy
Copy link
Contributor Author

finovy commented Feb 1, 2024

hi 请问本次PR还有什么需要修改的地方吗

LeoQuote
LeoQuote requested changes Feb 1, 2024
View reviewed changes
common/static/dist/css/style.css Outdated Show resolved Hide resolved
@hhyo hhyo merged commit b390854 into hhyo:master Feb 3, 2024
10 checks passed
@finovy finovy deleted the feature-update-fed branch February 4, 2024 01:14
@LeoQuote LeoQuote mentioned this pull request Apr 11, 2024
Merged
hhyo added a commit that referenced this pull request Aug 24, 2024
@hhyo
Revert "对导航菜单进行优化 (#2494)"
a41e42b 
This reverts commit b390854
hhyo added a commit that referenced this pull request Aug 24, 2024
@hhyo
回退导航和前端调整 (#2771)
0eb2c8c 
* Revert "对导航菜单进行优化 (#2494)"

This reverts commit b390854

* 修复bootstrap-table升级后账号权限展示异常的问题

* 版本变更
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoQuote LeoQuote LeoQuote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finovy @LeoQuote @hhyo