Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

在前端独立展示审批流 #2423

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

LeoQuote
Copy link
Collaborator

图片

#2394 合并之后, 发现表格有时候会太宽了, 尤其是节点比较多, 节点名字比较长的情况

所以把这一块直接独立出来了

独立同时也把 query, 上线工单, archive 工单的审批流展示统一了, 现在都是一样都会显示审批流

TODO:

  1. 可能要补一下测试
  2. 有一点残留的老 review_info 没删, 等删除了统一把方法也清理掉

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f483213) 76.37% compared to head (43baa78) 76.45%.

Files Patch % Lines
sql/utils/workflow_audit.py 92.59% 4 Missing ⚠️
sql/views.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2423      +/-   ##
==========================================
+ Coverage   76.37%   76.45%   +0.08%     
==========================================
  Files         115      115              
  Lines       15824    15845      +21     
==========================================
+ Hits        12085    12114      +29     
+ Misses       3739     3731       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote marked this pull request as ready for review November 29, 2023 06:21
@LeoQuote LeoQuote merged commit e40d728 into hhyo:master Nov 29, 2023
10 checks passed
@LeoQuote LeoQuote deleted the standalone_workflow branch November 29, 2023 06:24
pengkang1991 added a commit to pengkang1991/Archery that referenced this pull request Nov 29, 2023
在前端独立展示审批流 (hhyo#2423)
pengkang1991 added a commit to pengkang1991/Archery that referenced this pull request Nov 29, 2023
pengkang1991 added a commit to pengkang1991/Archery that referenced this pull request Nov 29, 2023
Revert "在前端独立展示审批流 (hhyo#2423)"
pengkang1991 added a commit to pengkang1991/Archery that referenced this pull request Nov 29, 2023
在前端独立展示审批流 (hhyo#2423)
finovy pushed a commit to finovy/Archery that referenced this pull request Dec 1, 2023
* 在前端独立展示审批流

* 修复测试

* 删除老 review_info

* 增加 archive detail view 的测试
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant