Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

用 WorkflowType 和 WorkflowStatus 两个 enum 替换WorkflowDict #2344

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

LeoQuote
Copy link
Collaborator

enum 在这里更合适, dict 使用不是很方便, 编辑器没有 hint, type hint 也没有.

以后直接 WorkflowType.QUERY 就可以引用.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1fbf6ed) 75.68% compared to head (280f92e) 75.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2344   +/-   ##
=======================================
  Coverage   75.68%   75.69%           
=======================================
  Files         108      108           
  Lines       15701    15707    +6     
=======================================
+ Hits        11883    11889    +6     
  Misses       3818     3818           
Files Coverage Δ
common/utils/const.py 100.00% <100.00%> (ø)
common/workflow.py 22.50% <100.00%> (ø)
sql/archiver.py 57.03% <100.00%> (ø)
sql/models.py 96.57% <100.00%> (-0.01%) ⬇️
sql/notify.py 89.81% <100.00%> (ø)
sql/sql_workflow.py 62.23% <100.00%> (ø)
sql/tests.py 98.77% <100.00%> (ø)
sql/utils/execute_sql.py 81.35% <100.00%> (ø)
sql/utils/tests.py 100.00% <100.00%> (ø)
sql/utils/workflow_audit.py 97.01% <100.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote merged commit fa2bb13 into hhyo:master Oct 23, 2023
10 checks passed
@LeoQuote LeoQuote deleted the replace_enum branch October 23, 2023 07:44
finovy pushed a commit to finovy/Archery that referenced this pull request Nov 10, 2023
* 用 WorkflowType 和 WorkflowStatus 两个 enum 替换WorkflowDict

* black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant