-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
将阿里云RDS的功能抽到单独engine #2087
将阿里云RDS的功能抽到单独engine #2087
Conversation
Conflicts: sql/db_diagnostic.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
处理一下lint检测,其实rds这些接口是否还存在都不是很清楚了
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 75.24% 75.14% -0.10%
==========================================
Files 105 105
Lines 15183 15167 -16
==========================================
- Hits 11424 11397 -27
- Misses 3759 3770 +11
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint还是需要修一下
相关api已经被移除,先合并,有rds管理需求的自行接入吧 |
阿里云RDS之前的处理方式不够优雅,将相关方法放到单独engine,同时方便其他RDS使用类似方式在engine定制功能。
同时修复一些拼写错误。
我没有阿里云RDS的资源,烦请有资源的同学帮忙测试功能。