Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

将阿里云RDS的功能抽到单独engine #2087

Merged
merged 8 commits into from
Jun 18, 2023
Merged

将阿里云RDS的功能抽到单独engine #2087

merged 8 commits into from
Jun 18, 2023

Conversation

weideguo
Copy link
Collaborator

阿里云RDS之前的处理方式不够优雅,将相关方法放到单独engine,同时方便其他RDS使用类似方式在engine定制功能。
同时修复一些拼写错误。
我没有阿里云RDS的资源,烦请有资源的同学帮忙测试功能。

@weideguo weideguo changed the title 将阿里云RDB的功能抽到单独engine 将阿里云RDSS的功能抽到单独engine Mar 17, 2023
@weideguo weideguo changed the title 将阿里云RDSS的功能抽到单独engine 将阿里云RDS的功能抽到单独engine Mar 17, 2023
Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

处理一下lint检测,其实rds这些接口是否还存在都不是很清楚了

sql/db_diagnostic.py Outdated Show resolved Hide resolved
sql/db_diagnostic.py Outdated Show resolved Hide resolved
sql/slowlog.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 7.01% and project coverage change: -0.10 ⚠️

Comparison is base (a794389) 75.24% compared to head (bffbd26) 75.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2087      +/-   ##
==========================================
- Coverage   75.24%   75.14%   -0.10%     
==========================================
  Files         105      105              
  Lines       15183    15167      -16     
==========================================
- Hits        11424    11397      -27     
- Misses       3759     3770      +11     
Impacted Files Coverage Δ
sql/engines/__init__.py 66.01% <ø> (ø)
sql/engines/cloud/aliyun_rds.py 0.00% <0.00%> (ø)
sql/slowlog.py 20.95% <0.00%> (-1.17%) ⬇️
sql/urls.py 100.00% <ø> (ø)
sql/db_diagnostic.py 16.08% <25.00%> (+0.49%) ⬆️
sql/engines/mysql.py 77.74% <100.00%> (ø)
sql/engines/tests.py 99.79% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint还是需要修一下

@hhyo
Copy link
Owner

hhyo commented Jun 18, 2023

相关api已经被移除,先合并,有rds管理需求的自行接入吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants