fix: 支持使用create or replace创建函数、存储过程、视图以及包等语句 #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
原来代码只支持使用create创建函数、存储过程、视图以及包，使用create or replace创建时获取不到对象名导致报错，实际运维中上线SQL大多使用create or replace方式，修改后同时支持使用create 和 create or replace两个方式。
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
+ Coverage 75.00% 75.02% +0.01%
==========================================
Files 102 102
Lines 14820 14811 -9
==========================================
- Hits 11116 11112 -4
+ Misses 3704 3699 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
nick2wang
previously requested changes
Mar 1, 2023
fix-支持Oracle创建存储过程、函数、包等，使用create or replace方式
重新修改了提交代码，原对象存在，告警提示： |
LeoQuote
reviewed
Mar 3, 2023
优化使用正则提取SQL语句中 object name 部分的代码逻辑
LeoQuote
reviewed
Mar 8, 2023
优化获取object name部分代码
|
感谢! 代码风格基本没什么问题了, 请看一下 CI 相关的报错, 修一下 lint 和 test 错误就可以了 |
优化代码
修复lint报错（代码规范）
处理lint报错（代码规范）
调整代码规范
lint 和 test 部分错误已修复，codecov/patch 的报错需要处理吗？ |
|
不强求, codecov 是对覆盖率的要求, 如果你要做的话我就再等等你, 不做的话我就现在 merge |
直接merge吧，谢谢！ |
LeoQuote
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原来代码只支持使用create创建函数、存储过程、视图以及包，使用create or replace创建时获取不到对象名导致报错，实际运维中上线SQL大多使用create or replace方式，修改后同时支持使用create 和 create or replace两个方式。