Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

给aggregate查询加limit行数限制,防止返回结果过多导致archery挂掉 #1948

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

czxin788
Copy link
Contributor

@czxin788 czxin788 commented Nov 2, 2022

fix bug:#1946

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 75.91% // Head: 75.90% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (17c3370) compared to base (3ff5c95).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   75.91%   75.90%   -0.01%     
==========================================
  Files          91       91              
  Lines       14203    14204       +1     
==========================================
  Hits        10782    10782              
- Misses       3421     3422       +1     
Impacted Files Coverage Δ
sql/engines/mongo.py 49.79% <0.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nick2wang
Copy link
Collaborator

重新跑了一遍CI都通过了,还有一个lint报错劳烦用black格式化下代码就可以了

@czxin788
Copy link
Contributor Author

czxin788 commented Nov 4, 2022

明白了,用black格式化以后,将'$limit'修改成"$limit"了,引号的问题

@nick2wang nick2wang merged commit 027904f into hhyo:master Nov 4, 2022
nick2wang pushed a commit to nick2wang/Archery that referenced this pull request Nov 8, 2022
* mongo aggregate查询加limit行数限制,防止返回结果过多导致archery挂掉

(cherry picked from commit 027904f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants