Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL检测和提交接入api方法 #1668

Merged
merged 3 commits into from
Sep 17, 2022
Merged

SQL检测和提交接入api方法 #1668

merged 3 commits into from
Sep 17, 2022

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Jul 9, 2022

  1. 将SQL检测和提交接入api方法,废弃原有实现
  2. ExecuteCheck、WorkflowList两个视图权限替换为 permissions.IsAuthenticated,并增加单独的操作权限校验
  3. SQL工单列表和提交增加权限资源权限校验,只能操作有权限的资源
  4. ExecuteCheck 增加异常捕获,避免配置异常时无错误信息提示

@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Base: 76.21% // Head: 76.10% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (ac8c7e6) compared to base (0977504).
Patch coverage: 84.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   76.21%   76.10%   -0.12%     
==========================================
  Files          91       91              
  Lines       14319    14181     -138     
==========================================
- Hits        10913    10792     -121     
+ Misses       3406     3389      -17     
Impacted Files Coverage Δ
sql/sql_workflow.py 62.23% <ø> (-5.85%) ⬇️
sql/tests.py 98.87% <ø> (-0.08%) ⬇️
sql/urls.py 100.00% <ø> (ø)
sql/views.py 63.45% <ø> (-0.91%) ⬇️
sql_api/api_workflow.py 69.26% <71.42%> (+3.74%) ⬆️
sql_api/serializers.py 80.05% <76.92%> (+0.95%) ⬆️
sql/models.py 96.57% <100.00%> (ø)
sql_api/tests.py 100.00% <100.00%> (ø)
sql/engines/goinception.py 65.55% <0.00%> (-0.33%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoQuote
Copy link
Collaborator

api部分的测试好像少了点啊🤔,看能不能按CI的提示补一补

@bardyang

This comment was marked as off-topic.

@hhyo hhyo merged commit bd15af2 into master Sep 17, 2022
@hhyo hhyo deleted the to-api branch September 17, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants