-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加登录审计日志 #1251
增加登录审计日志 #1251
Conversation
同步官网更新到功能特性开发分支
@hhyo review一下 |
Travis CI build failed 是因为: |
|
@hhyo 咦, 现在已经不用 migration 了吗....我弄错了? |
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 77.96% 77.90% -0.07%
==========================================
Files 76 77 +1
Lines 11970 12045 +75
==========================================
+ Hits 9333 9384 +51
- Misses 2637 2661 +24
Continue to review full report at Codecov.
|
我把migrations提交了,ci成功了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
审计日志不错,不过是否可以扩充一些,不仅限于登录,可以额外记录一些敏感操作
-
同时建议补充SQL文件,还是有很多是不依靠migrate升级的
|
同步upstream更新到开发分支
将审计功能全部抽到一个菜单栏是否是个好主意? |
管理端和用户端能够有不同的入口可能会比较好,不过当前都混一起了,单独做个审计页面的话,看怎么重新设计下,感谢你的贡献,方便的话辛苦加一下我的微信rtttte
|
Archery版本:1.8.1
功能:增加登入、登出、登入失败 审计日志
表结构:
变更文件:
界面截屏: