Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ 功能建议 ] SQL上线添加执行时间选择 #251

Closed
yzypals opened this issue Jun 5, 2019 · 5 comments
Closed

[ 功能建议 ] SQL上线添加执行时间选择 #251

yzypals opened this issue Jun 5, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@yzypals
Copy link
Collaborator

yzypals commented Jun 5, 2019

目前遇到的问题/使用障碍

sql上线 审批通过后，随时都可以执行，

希望如何解决/实现它

希望能添加可选的 执行时间区间选项，如果选了 就需要再指定的时间区域内才能执行，没选就审批完成就可以随时执行

其他信息

如果有其他类似的产品功能或者图片信息，可在此提交
@yzypals
Copy link
Collaborator Author

yzypals commented Jun 5, 2019

这个功能 感觉可以考虑， 线上数据库 不能随时上线的 ，需要指定时间才可以执行 。
定时执行虽然可以满足部分上述诉求 ， 但不够灵活。 功能我先做起来

@hhyo
Copy link
Owner

hhyo commented Jun 5, 2019

如果在提交时选择的话，开发人员不一定清楚数据库的压力情况，时间限定可以由最终审核人一般是dba来选择

其实最理想的状态是平台能够自己判断并且自动在业务低峰执行

其次这个限制是实例的维度还是工单的维度可以讨论一下

挺好的需求

@yzypals
Copy link
Collaborator Author

yzypals commented Jun 6, 2019

功能做好了 提pr了

@stale stale bot added the wontfix This will not be worked on label Jun 9, 2019
Repository owner deleted a comment from stale bot Jun 9, 2019
@stale stale bot removed the wontfix This will not be worked on label Jun 9, 2019
@hhyo
Copy link
Owner

hhyo commented Jun 9, 2019

#257

@hhyo hhyo added the enhancement New feature or request label Jun 9, 2019
@fancy-lee
Copy link
Contributor

这个需求我们也有，开发人员也会考虑执行时间，审核的时候审核人员最好可以修改

@hhyo hhyo closed this as completed Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hhyo @fancy-lee @yzypals