Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

系统设置，AUTO_REVIEW_WRONG失效的问题。 #1462

Closed
thcoffee opened this issue Apr 13, 2022 · 5 comments
Closed

系统设置，AUTO_REVIEW_WRONG失效的问题。 #1462

thcoffee opened this issue Apr 13, 2022 · 5 comments
Labels
question Further information is requested

Comments

@thcoffee
Copy link
Contributor

thcoffee commented Apr 13, 2022 •
edited
Loading

问题描述

系统设置 AUTO_REVIEW_WRONG =1 ，告警就上线自动驳回，mysql是可以的。 但是oracle就不行。oracle已经告警了。也不自动驳回。
请问大家知道怎么回事么。

版本信息

  • 应用版本/分支：Release v1.8.3
  • 部署方式：Docker
@thcoffee thcoffee added the question Further information is requested label Apr 13, 2022
@hhyo
Copy link
Owner

hhyo commented Apr 17, 2022

#1452

@thcoffee
Copy link
Contributor Author

#1452

十分感谢 ，不是一件事 ，您发的这个AUTO_REVIEW_DB_TYPE支持oracle是针对AUTO_REVIEW这个的辅助选项。 我说的这个是AUTO_REVIEW_WRONG，这个就算不开自动审核，只要sql审查告警就自动驳回了。

我根据您的提示打开了AUTO_REVIEW选项，设置了AUTO_REVIEW_DB_TYPE支持mysql和oracle。删除行数超过设置的值，仍然不自动驳回。
image

@thcoffee
Copy link
Contributor Author

image
这里就算我把AUTO_REVIEW关闭掉，仍然会自动驳回。只要我将AUTO_REVIEW_WRONG =1 就可以。

@hhyo
Copy link
Owner

hhyo commented Apr 18, 2022

看了下这个是非MySQL的审核结果没有注入error和warning数量导致，后面可以修复一下

@thcoffee
Copy link
Contributor Author

看了下这个是非MySQL的审核结果没有注入error和warning数量导致，后面可以修复一下

十分感谢

@hhyo hhyo closed this as completed in eb999f1 Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hhyo @thcoffee