Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor incorrectness of diagram legend #1285

Open
lucasturci opened this issue Aug 26, 2022 · 0 comments
Open

Minor incorrectness of diagram legend #1285

lucasturci opened this issue Aug 26, 2022 · 0 comments

Comments

@lucasturci
Copy link

Where is the problem?

Section "A page as a Dependency Tree" of Asynchronous Operations Introduction

What is the problem?

The legend is not entirely correct. The block
Screenshot 2022-08-26 at 14 24 24

is true for "Render component A" -> "Fetch A cache misses via cURL", but not for "Fetch A cache misses via cURL" -> "Identify A cache misses". The second dependency is actually backwards, "Identify A cache misses" depends on "Fetch A cache misses via cURL" to have run.

I get the meaning intended, but I would suggest having another arrow type, with a different legend, because this can be a little confusing when comparing this diagram with the others that follow. Also, if other diagrams can be provided with a legend, the page would be brilliant.

Btw, leaving here my appreciation to that page, I think it's very helpful to understand how hack asynchrony works :).


Please don't change anything below this point.


  • Build ID: HHVM=HHVM-4.164.0:HSL=v4.108.1:2022-08-26T00:00:37+0000:1fa47f258c6b68f8ec01899aa82fd6ffa0957109
  • Page requested: /hack/asynchronous-operations/introduction
  • Page requested at: Fri, 26 Aug 2022 13:17:27 +0000
  • Controller: GuidePageController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant