Skip to content

Support Dual Package #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Dual Package #139

wants to merge 1 commit into from

Conversation

@kabszac
Copy link

@kabszac kabszac commented Aug 3, 2023

Added "type": "module" to package.json.

this closes #138

@hg-pyun
Copy link
Owner

hg-pyun commented Aug 11, 2023

@kabszac

Supporting dual packages is not simple. The commit below is the process I tried. To support dual package, you must build with cjs and esm and set it up through separate export fields. This may require a separate build pipeline.

b14bab5

@kabszac
Copy link
Author

kabszac commented Aug 16, 2023

@hg-pyun
Sorry I didn't get you well on how to about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Dual Package

2 participants

@kabszac @hg-pyun