-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running into issues trying out the examples #13
Comments
It looks like it broke with the reselect v4 release. Pretty sure it was reduxjs/reselect#297; reselect-map passes in a custom memoization function, but only expects it to be used for the final selector. I'll try to figure out a fix in the next couple of days. |
Ah I see, I guess it's runkit's fault that it's not following your peer dependency assertion: |
https://github.com/reduxjs/reselect#q-how-do-i-create-a-selector-that-takes-an-argument I think this can help in this case. Doing the memoization as part of the final step? What do you think? |
Hey, thanks for the report! I've committed a fix and should publish the new version to npm tonight. |
@heyimalex Thanks so much for the quick update! Can you publish if possible? :) |
It should be up now! |
https://runkit.com/embed/lzksevx8x4ok
I ran the above, and continuously get an empty array. I also tried to do the same with createObjectSelector, but it was hitting some crashes. Any help on this would be great.
Thanks!
The text was updated successfully, but these errors were encountered: