Skip to content

Commit 0ec763c

Browse files
committed
fixing a margin calculation issue for nested rows
1 parent 2f0bb46 commit 0ec763c

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

example/scss/example-fluid.scss

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
$grid-clearfix-class: false;
1+
$grid-clearfix-class: false; // don't auto create the clearfix
22

33
// import the grid
44
@import "grid/fluid";
@@ -10,7 +10,7 @@ $grid-clearfix-class: false;
1010

1111
// main page sections
1212
[role="main"] {
13-
@include fluid-row(true); //true indicates a row is directly inside a page
13+
@include fluid-row(true); // row is directly inside a page
1414
}
1515

1616
// header and footer don't have columns in this example
@@ -20,14 +20,19 @@ header, footer {
2020
margin-bottom: $grid-gutter-width;
2121
}
2222

23+
// column rules so that float and border-box aren't repeated
24+
.column {
25+
@include fluid-column($with-gutters: false); // omit gutters
26+
}
27+
2328
// side columns
2429
#left-column, #right-column {
25-
@include fluid-column($with-gutters: false);
30+
@extend .column;
2631
border: 1px solid red;
2732
}
2833
#left-column {
29-
@include fluid(3, 0); //3 columns wide, don't adjust for border
30-
@include fluid-gutters; // normal gutters
34+
@include fluid(3); //3 columns wide, don't adjust for border
35+
@include fluid-gutters; // gutters
3136
}
3237
#right-column {
3338
@include fluid(3, 0, 9); //3 columns wide, 9 column parent, don't adjust for border
@@ -36,7 +41,9 @@ header, footer {
3641

3742
// main column
3843
#main-column {
39-
@include fluid-column(9); //9 columns wide
44+
@extend .column;
45+
@include fluid(9); //9 columns wide
46+
@include fluid-gutters; // gutters
4047

4148
// sections in the main column are rows
4249
> section {
@@ -54,8 +61,11 @@ header, footer {
5461

5562
// center column
5663
#content {
57-
@include fluid-column(6, 0, 9); //6 columns wide, adjust for border, don't adjust for border
64+
@extend .column;
65+
@include fluid(6, 0, 9); //6 columns wide, don't adjust for border
66+
@include fluid-gutters(9); // gutters
5867
border: 1px solid blue;
5968
}
6069

70+
// define our own clearfix
6171
.clearfix { @include pie-clearfix; }

stylesheets/grid/_fluid.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
// apply standard gutters to a column or row
2222
@mixin fluid-gutters($parent: $grid-columns, $parent-plus: 0, $row: false) {
23-
margin: 0 fluid-width($grid-gutter-width / 2 * if($row, -1, 1), grid-column-width($parent, $parent-plus + $grid-gutter-width));
23+
margin: 0 fluid-width($grid-gutter-width / 2 * if($row, -1, 1), grid-column-width($parent, $parent-plus + if($row, 0, $grid-gutter-width)));
2424
}
2525

2626
// return a percentage width relative to a column width

0 commit comments

Comments
 (0)