Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed_tag() helper #120

Closed
SukkaW opened this issue Dec 4, 2019 · 1 comment
Closed

feed_tag() helper #120

SukkaW opened this issue Dec 4, 2019 · 1 comment
Assignees

Comments

@SukkaW
Copy link
Member

SukkaW commented Dec 4, 2019

The idea of bring up a hexo built-in RSS autodiscovery helper comes from #115. I notice that there is already a feed_tag() helper: https://github.com/hexojs/hexo/blob/master/lib/plugins/helper/feed_tag.js

The problem is:

  • The hexo's built-in feed_tag() doesn't support type
  • The helper still requires manually setup.

We should bring up a helper that output autodiscovery tag automatically based on the config. Since it will be a helper maintained by us, it only requires theme developer to put something like <%- feed_autodiscovery() %> in the layout without worrying about the Breaking Changes of the plugins.

cc @AlynxZhou @stevenjoezhang

@SukkaW
Copy link
Member Author

SukkaW commented Jan 8, 2020

Fixed in hexojs/hexo#4029

@SukkaW SukkaW closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant