Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers.make_epc_qr: encoding should accept a charset name or numeric constant #72

Closed
heuer opened this issue Feb 19, 2020 · 0 comments
Closed

helpers.make_epc_qr: encoding should accept a charset name or numeric constant #72

heuer opened this issue Feb 19, 2020 · 0 comments
Labels
enhancement

Comments

@heuer
Copy link
Owner

heuer commented Feb 19, 2020

Currently helpers.make_epc_qr expects a numeric constant like 1 for utf-8.

Would be much more user friendly if encoding accepts the name of the encoding as well.

qr = helpers.make_epc_qr(..., encoding='utf-8')
qr = helpers.make_epc_qr(..., encoding='iso-8859-1')
[...]

An unsupported encoding should raise a ValueError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@heuer