Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hetznercloud/hcloud-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.17.0
Choose a base ref
...
head repository: hetznercloud/hcloud-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.18.0
Choose a head ref
  • 6 commits
  • 80 files changed
  • 5 contributors

Commits on Aug 5, 2022

  1. Remove use of external mock module (#162)

    Python since 3.4 has included mock in the standard library, under the
    unittest module. Since the lowest version supported is greater than
    that, we can switch to using it and drop one external requirement.
    s-t-e-v-e-n-k authored Aug 5, 2022
    Configuration menu
    Copy the full SHA
    b55756f View commit details
    Browse the repository at this point in the history
  2. document installation path via conda-forge (#149)

    * install via conda-forge
    
    Co-authored-by: Lukas Kämmerling <github@lukas-kaemmerling.de>
    s-m-e and LKaemmerling authored Aug 5, 2022
    Configuration menu
    Copy the full SHA
    cdf0ce5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32bd2ec View commit details
    Browse the repository at this point in the history
  4. Simplify Requirement Constraints (#163)

    This includes the remove of the upper boundary.
    
    Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
    LKaemmerling authored Aug 5, 2022
    Configuration menu
    Copy the full SHA
    76ec7ed View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Add validation helper for Label Values/Keys (#164)

    * Add validation helper for Label Values/Keys
    
    This implementation is similar to the implementation in the hcloud-go. To give the "user" as much as verbosity as possible i introduced two methods.
    
    - `validate` which is a simple validator that just returns True/False.add-validator-for-labels
    - `validate_verbose` which also returns the corresponding error message (like which key/value is not correctly formatted)
    
    I decided against calling one of both function in the other and instead duplicate the code. This is based on my feeling that the code would be more complex when we as a sample call validate_verbose in validate. Also, it is slightly more readable imho, but we can discuss this :)
    
    Closes #153
    
    Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
    
    * Fix tox
    
    Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
    
    Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
    LKaemmerling authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    090be27 View commit details
    Browse the repository at this point in the history
  2. Bum Version

    LKaemmerling authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    c2de84e View commit details
    Browse the repository at this point in the history
Loading