Skip to content

Commit dc3bc93

Browse files
committed
refactor: do not use isoparse in expected values
1 parent aa5b84c commit dc3bc93

File tree

6 files changed

+29
-22
lines changed

6 files changed

+29
-22
lines changed

tests/unit/core/test_domain.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
from __future__ import annotations
22

3+
from datetime import datetime
4+
35
import pytest
4-
from dateutil.parser import isoparse
56

67
from hcloud.core import BaseDomain, DomainIdentityMixin, Meta, Pagination
78

@@ -99,7 +100,7 @@ class ActionDomain(BaseDomain, DomainIdentityMixin):
99100
def __init__(self, id, name="name1", started=None):
100101
self.id = id
101102
self.name = name
102-
self.started = isoparse(started) if started else None
103+
self.started = self._parse_datetime(started)
103104

104105

105106
class SomeOtherDomain(BaseDomain):
@@ -133,7 +134,7 @@ class TestBaseDomain:
133134
{
134135
"id": 4,
135136
"name": "name-name3",
136-
"started": isoparse("2016-01-30T23:50+00:00"),
137+
"started": datetime.fromisoformat("2016-01-30T23:50+00:00"),
137138
},
138139
),
139140
],

tests/unit/networks/test_client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from __future__ import annotations
22

3+
from datetime import datetime, timezone
34
from unittest import mock
45

56
import pytest
6-
from dateutil.parser import isoparse
77

88
from hcloud import Client
99
from hcloud.networks import (
@@ -44,7 +44,9 @@ def test_init(self, network_response):
4444
)
4545

4646
assert bound_network.id == 1
47-
assert bound_network.created == isoparse("2016-01-30T23:50:11+00:00")
47+
assert bound_network.created == datetime(
48+
2026, 1, 30, 23, 50, 11, tzinfo=timezone.utc
49+
)
4850
assert bound_network.name == "mynet"
4951
assert bound_network.ip_range == "10.0.0.0/16"
5052
assert bound_network.protection["delete"] is False

tests/unit/storage_box_types/test_client.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
from __future__ import annotations
44

5+
from datetime import datetime, timezone
56
from unittest import mock
67

78
import pytest
8-
from dateutil.parser import isoparse
99

1010
from hcloud import Client
1111
from hcloud.storage_box_types import (
@@ -58,9 +58,11 @@ def test_get_by_id(
5858
"setup_fee": {"gross": "0.0000", "net": "0.0000"},
5959
}
6060
]
61-
assert result.deprecation.announced == isoparse("2023-06-01T00:00:00+00:00")
62-
assert result.deprecation.unavailable_after == isoparse(
63-
"2023-09-01T00:00:00+00:00"
61+
assert result.deprecation.announced == datetime(
62+
2023, 6, 1, 0, 0, 0, tzinfo=timezone.utc
63+
)
64+
assert result.deprecation.unavailable_after == datetime(
65+
2023, 9, 1, 0, 0, 0, tzinfo=timezone.utc
6466
)
6567

6668
@pytest.mark.parametrize(

tests/unit/storage_boxes/test_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
from __future__ import annotations
44

5+
from datetime import datetime, timezone
56
from unittest import mock
67

78
import pytest
8-
from dateutil.parser import isoparse
99

1010
from hcloud import Client
1111
from hcloud.locations import Location
@@ -122,7 +122,7 @@ def test_init(self, bound_model: BoundStorageBox, resource_client):
122122
assert o.stats.size_data == 2102612983808
123123
assert o.stats.size_snapshots == 239623733248
124124
assert o.status == "active"
125-
assert o.created == isoparse("2025-01-30T23:55:00Z")
125+
assert o.created == datetime(2025, 1, 30, 23, 50, 00, tzinfo=timezone.utc)
126126

127127

128128
class TestBoundStorageBoxSnapshot(BoundModelTestCase):
@@ -156,7 +156,7 @@ def test_init(self, bound_model: BoundStorageBoxSnapshot, resource_client):
156156
assert o.labels == {"key": "value"}
157157
assert o.stats.size == 394957594
158158
assert o.stats.size_filesystem == 3949572745
159-
assert o.created == isoparse("2025-11-10T19:16:57Z")
159+
assert o.created == datetime(2025, 11, 10, 19, 16, 57, tzinfo=timezone.utc)
160160

161161
def test_reload(
162162
self,
@@ -232,7 +232,7 @@ def test_init(self, bound_model: BoundStorageBoxSubaccount, resource_client):
232232
assert o.access_settings.webdav_enabled is False
233233
assert o.access_settings.readonly is False
234234
assert o.labels == {"key": "value"}
235-
assert o.created == isoparse("2025-11-10T19:18:57Z")
235+
assert o.created == datetime(2025, 11, 10, 19, 18, 57, tzinfo=timezone.utc)
236236

237237
def test_reload(
238238
self,

tests/unit/volumes/test_client.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from __future__ import annotations
22

3+
from datetime import datetime, timezone
34
from unittest import mock
45

56
import pytest
6-
from dateutil.parser import isoparse
77

88
from hcloud import Client
99
from hcloud.locations import BoundLocation, Location
@@ -37,7 +37,9 @@ def test_bound_volume_init(self, volume_response):
3737
)
3838

3939
assert bound_volume.id == 1
40-
assert bound_volume.created == isoparse("2016-01-30T23:50:11+00:00")
40+
assert bound_volume.created == datetime(
41+
2016, 1, 30, 23, 50, 11, tzinfo=timezone.utc
42+
)
4143
assert bound_volume.name == "database-storage"
4244
assert isinstance(bound_volume.server, BoundServer)
4345
assert bound_volume.server.id == 12

tests/unit/zones/test_client.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
from __future__ import annotations
44

5+
from datetime import datetime, timezone
56
from unittest import mock
67

78
import pytest
8-
from dateutil.parser import isoparse
99

1010
from hcloud import Client
1111
from hcloud.zones import (
@@ -73,7 +73,7 @@ def test_get_using_id(
7373
)
7474

7575
assert_bound_zone1(result, resource_client)
76-
assert result.created == isoparse("2016-01-30T23:55:00+00:00")
76+
assert result.created == datetime(2016, 1, 30, 23, 55, 00, tzinfo=timezone.utc)
7777
assert result.mode == "primary"
7878
assert result.ttl == 10800
7979
assert result.protection == {"delete": False}
@@ -89,8 +89,8 @@ def test_get_using_id(
8989
assert (
9090
result.authoritative_nameservers.delegated[0] == "hydrogen.ns.hetzner.com."
9191
)
92-
assert result.authoritative_nameservers.delegation_last_check == isoparse(
93-
"2016-01-30T23:55:00+00:00"
92+
assert result.authoritative_nameservers.delegation_last_check == datetime(
93+
2016, 1, 30, 23, 55, 0, tzinfo=timezone.utc
9494
)
9595
assert result.authoritative_nameservers.delegation_status == "valid"
9696

@@ -935,7 +935,7 @@ def test_init(self, resource_client: ZonesClient, bound_model: BoundZone):
935935

936936
assert o.id == 42
937937
assert o.name == "example1.com"
938-
assert o.created == isoparse("2016-01-30T23:55:00+00:00")
938+
assert o.created == datetime(2016, 1, 30, 23, 55, 0, tzinfo=timezone.utc)
939939
assert o.mode == "primary"
940940
assert o.ttl == 10800
941941
assert o.protection == {"delete": False}
@@ -960,8 +960,8 @@ def test_init(self, resource_client: ZonesClient, bound_model: BoundZone):
960960
"oxygen.ns.hetzner.com.",
961961
"helium.ns.hetzner.de.",
962962
]
963-
assert o.authoritative_nameservers.delegation_last_check == isoparse(
964-
"2016-01-30T23:55:00+00:00"
963+
assert o.authoritative_nameservers.delegation_last_check == datetime(
964+
2016, 1, 30, 23, 55, 0, tzinfo=timezone.utc
965965
)
966966
assert o.authoritative_nameservers.delegation_status == "valid"
967967

0 commit comments

Comments
 (0)